From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25606 invoked by alias); 12 Jan 2006 15:57:07 -0000 Received: (qmail 25597 invoked by uid 22791); 12 Jan 2006 15:57:06 -0000 X-Spam-Check-By: sourceware.org Received: from voldemort.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 12 Jan 2006 15:57:05 +0000 Received: (qmail 23415 invoked from network); 12 Jan 2006 15:57:03 -0000 Received: from unknown (HELO ?192.168.0.131?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 12 Jan 2006 15:57:03 -0000 Message-ID: <43C67C4C.7090605@codesourcery.com> Date: Thu, 12 Jan 2006 15:57:00 -0000 From: Mark Mitchell User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) MIME-Version: 1.0 To: Jim Blandy CC: gdb-patches@sources.redhat.com Subject: Re: PATCH: Detect closed file descriptors on Windows References: <200601112147.k0BLlatG000696@sethra.codesourcery.com> <8f2776cb0601111639r61642795la665387645e44bfa@mail.gmail.com> In-Reply-To: <8f2776cb0601111639r61642795la665387645e44bfa@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00125.txt.bz2 Jim Blandy wrote: > On 1/11/06, Mark Mitchell wrote: > >> gdb_assert (!FD_ISSET (fd, writefds)); >>! if (FD_ISSET (fd, readfds) >>! && !FD_ISSET (fd, exceptfds)) >>! continue; > > > Don't you mean, "if (! FD_ISSET (fd, readfds) && ..."? Definitely. I got lucky because GDB (at least in simple cases) tends to pass the same set of descriptors for readfds and exceptfds. OK with that change? Thanks, -- Mark Mitchell CodeSourcery mark@codesourcery.com (650) 331-3385 x713