Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sources.redhat.com
Subject: Re: How to implement gcore on pa-hpux ?
Date: Wed, 04 Jan 2006 19:12:00 -0000	[thread overview]
Message-ID: <43BC1DFF.2080501@redhat.com> (raw)
In-Reply-To: <20060104184050.GA8927@nevyn.them.org>

Daniel Jacobowitz wrote:
> On Wed, Jan 04, 2006 at 09:40:09PM +0400, Joel Brobecker wrote:
> 
>>So I created a new function in infttrace.c. In order to avoid re-writing
>>the part of gcore.c that add the command, and handles the arguments of this
>>command, I simply hooked the new infttrace directly into the gcore code.
>>A bit crude, but it works and it's pretty localized.
>>
>>For the FSF tree, I'd like to implement this a little better, and it
>>seems to me that the core part of this command, the part that actually
>>creates the core file, should be a method of some vector. But which
>>vector?
>>
>>The way the gcore command is currently written, it seems that it would
>>make sense for it to be part of the target vector. No?
>>
>>However, in the case of HP/UX, there is a slight complication, because
>>the method is only good in the native case...
> 
> 
> If you really mean target vector, then this isn't a complication at
> all.  The native case should have its own target vector already, in
> inf-ttrace.c (note the dash in modern sources).  Ideally remote targets
> could gcore; but there's been no interest in implementing that so far,
> so it's not worth concerning ourselves with until someone wants to work
> on it.

Alternatively...

The "gcore" command is actually defined in gcore.c.  If someone
(hpux) wanted to define it differently, it should be as simple as
linking in your own (eg.) hpux-gcore.c module, *instead of* the
generic gcore.c module.

Current targets that implement gcore in the generic way
do so by adding gcore.o to the NATDEPFILES.


  reply	other threads:[~2006-01-04 19:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-04 17:40 Joel Brobecker
2006-01-04 18:40 ` Daniel Jacobowitz
2006-01-04 19:12   ` Michael Snyder [this message]
2006-01-05  3:24     ` Joel Brobecker
2006-01-06  4:40       ` Michael Snyder
2006-01-06 10:28         ` Joel Brobecker
2006-01-06 13:43           ` Daniel Jacobowitz
2006-01-09  5:59             ` Joel Brobecker
2006-01-22 20:43               ` Daniel Jacobowitz
2006-01-05  4:03   ` Joel Brobecker
2006-01-05  5:02     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43BC1DFF.2080501@redhat.com \
    --to=msnyder@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox