Re: How to implement gcore on pa-hpux ?

[Daniel Jacobowitz <drow@false.org>]

On Mon, Jan 09, 2006 at 09:58:48AM +0400, Joel Brobecker wrote:
> > On Fri, Jan 06, 2006 at 02:28:24PM +0400, Joel Brobecker wrote:
> > > It's not as elegant as having a gdbarch or target method, but it's
> > > probably easier to implement. We defer a bit the work that makes this
> > > a method of some vector, but it's not necessary right now. Perhaps
> > > the pragmatic thing to do would be to wait until we need it before
> > > we start worrying about it. Even then, the work is slightly prepared
> > > because we already have the genericity based on the hook.
> > > 
> > > What do you guys think?
> > 
> > I think that if you need to add new files and rely on magic function
> > names, then you're already past the time when you needed to add things
> > to a vector.
> 
> Magic function name? Ouch, my heart ;-).
> 
> OK, will try to play with the target vector. For the record, here is
> what I had in mind. I implemented it because it's not that far off the
> road to using the target vector. In this case, it's the gcore module
> itself that holds the method pointer rather than the target vector.
> It's not as powerful, because it is not dynamic the way target vectors
> are, but it's not worse than before.

Thanks.  FYI, this patch is a perfect example of why I want you to use
the target vector instead:

> @@ -1156,5 +1195,6 @@ _initialize_inf_ttrace (void)
>  {
>  #ifdef HAVE_TTRACE
>    inf_ttrace_page_dict.pagesize = getpagesize();
> +  gcore_set_write_core (inf_ttrace_write_core);
>  #endif
>  }

inf_ttrace_write_core is only going to work when debugging using
ttrace.  Just because it's an HP/UX system doesn't mean we aren't
connected to some non-native target.

-- 
Daniel Jacobowitz
CodeSourcery