[PATCH] thread apply help

[PATCH] thread apply help

[Andrew STUBBS]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

Hi,

This patch might qualify as obvious, but I'm not sure what the rules are 
on who's allowed to do that, so here it is.

Currently GDB reports the following:

   (gdb) help thread apply
   Apply a command to a list of threads.

   List of apply subcommands:

   apply all -- Apply a command to all threads

   Type "help apply" followed by apply subcommand name for full
   documentation.
   Command name abbreviations are allowed if unambiguous.

The word 'thread' is missing in four places. It should read as follows:

   (gdb) help thread apply
   Apply a command to a list of threads.

   List of thread apply subcommands:

   thread apply all -- Apply a command to all threads

   Type "help thread apply" followed by thread apply subcommand name for
   full documentation.
   Command name abbreviations are allowed if unambiguous.

OK?

Andrew Stubbs

[-- Attachment #2: thread_apply.patch --]
[-- Type: text/plain, Size: 755 bytes --]

2005-11-09  Andrew Stubbs  <andrew.stubbs@st.com>

	* thread.c (_initialize_thread): Correct the 'thread apply' help
	message.

Index: src/gdb/thread.c
===================================================================
--- src.orig/gdb/thread.c	2005-02-15 15:49:22.000000000 +0000
+++ src/gdb/thread.c	2005-11-02 16:01:51.000000000 +0000
@@ -691,7 +691,7 @@ The new thread ID must be currently know
 
   add_prefix_cmd ("apply", class_run, thread_apply_command,
 		  _("Apply a command to a list of threads."),
-		  &thread_apply_list, "apply ", 1, &thread_cmd_list);
+		  &thread_apply_list, "thread apply ", 1, &thread_cmd_list);
 
   add_cmd ("all", class_run, thread_apply_all_command,
 	   _("Apply a command to all threads."), &thread_apply_list);

Re: [PATCH] thread apply help

[Daniel Jacobowitz]

On Wed, Nov 09, 2005 at 06:05:36PM +0000, Andrew STUBBS wrote:
> Hi,
> 
> This patch might qualify as obvious, but I'm not sure what the rules are 
> on who's allowed to do that, so here it is.

Anyone who can commit a patch.  See MAINTAINERS for the description of
this.

> 2005-11-09  Andrew Stubbs  <andrew.stubbs@st.com>
> 
> 	* thread.c (_initialize_thread): Correct the 'thread apply' help
> 	message.

Yes, this is fine.  It'd be nice if the CLI code handled this
automatically, but obviously it doesn't, so...

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [PATCH] thread apply help

[Andrew STUBBS]

Daniel Jacobowitz wrote:
>>This patch might qualify as obvious, but I'm not sure what the rules are 
>>on who's allowed to do that, so here it is.
> 
> Anyone who can commit a patch.  See MAINTAINERS for the description of
> this.

Actually, the MAINTAINERS file says 'All maintainers listed in this 
file'. I am neither a maintainer, nor listed in that file.

> Yes, this is fine.  It'd be nice if the CLI code handled this
> automatically, but obviously it doesn't, so...

Commited.

Thanks

Andrew Stubbs

Re: [PATCH] thread apply help

[Andrew STUBBS]

Daniel Jacobowitz wrote:
> On Mon, Nov 14, 2005 at 05:08:12PM +0000, Andrew STUBBS wrote:
> 
>>Daniel Jacobowitz wrote:
>>
>>>>This patch might qualify as obvious, but I'm not sure what the rules are 
>>>>on who's allowed to do that, so here it is.
>>>
>>>Anyone who can commit a patch.  See MAINTAINERS for the description of
>>>this.
>>
>>Actually, the MAINTAINERS file says 'All maintainers listed in this 
>>file'. I am neither a maintainer, nor listed in that file.
> 
> 
> You have write after approval access, so you're supposed to be.  Please
> add yourself to the alphabetical list near the bottom.

OK, I've done that now.

Andrew Stubbs

Re: [PATCH] thread apply help

[Daniel Jacobowitz]

On Mon, Nov 14, 2005 at 05:08:12PM +0000, Andrew STUBBS wrote:
> Daniel Jacobowitz wrote:
> >>This patch might qualify as obvious, but I'm not sure what the rules are 
> >>on who's allowed to do that, so here it is.
> >
> >Anyone who can commit a patch.  See MAINTAINERS for the description of
> >this.
> 
> Actually, the MAINTAINERS file says 'All maintainers listed in this 
> file'. I am neither a maintainer, nor listed in that file.

You have write after approval access, so you're supposed to be.  Please
add yourself to the alphabetical list near the bottom.

-- 
Daniel Jacobowitz
CodeSourcery, LLC