Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew STUBBS <andrew.stubbs@st.com>
To: gdb-patches@sources.redhat.com
Subject: PATCH: Fix -w option
Date: Tue, 25 Oct 2005 22:22:00 -0000	[thread overview]
Message-ID: <435E2756.8060103@st.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

Hi,

The -w option does not do anything anymore.

The attached patch fixes the problem and allows it to open Insight once 
more. It also tidies up the use of interpreter_p a little wrt the tui.

Andrew Stubbs

[-- Attachment #2: option_-w_fix.patch --]
[-- Type: text/plain, Size: 1413 bytes --]

2005-10-25  Andrew Stubbs  <andrew.stubbs@st.com>

	* main.c (main): Use INTERP_TUI instead of "tui".
	Set interpreter to INTERP_INSIGHT when '-w' given.
	* interps.h (INTERP_INSIGHT): New define.


Index: src/gdb/main.c
===================================================================
--- src.orig/gdb/main.c	2005-10-17 15:23:23.000000000 +0100
+++ src/gdb/main.c	2005-10-17 15:29:40.000000000 +0100
@@ -339,11 +339,16 @@ captured_main (void *data)
 	  case OPT_TUI:
 	    /* --tui is equivalent to -i=tui.  */
 	    xfree (interpreter_p);
-	    interpreter_p = xstrdup ("tui");
+	    interpreter_p = xstrdup (INTERP_TUI);
 	    break;
 	  case OPT_WINDOWS:
 	    /* FIXME: cagney/2003-03-01: Not sure if this option is
                actually useful, and if it is, what it should do.  */
+#ifdef GDBTK
+	    /* --windows is equivalent to -i=insight.  */
+	    xfree (interpreter_p);
+	    interpreter_p = xstrdup (INTERP_INSIGHT);
+#endif
 	    use_windows = 1;
 	    break;
 	  case OPT_NOWINDOWS:
Index: src/gdb/interps.h
===================================================================
--- src.orig/gdb/interps.h	2005-10-17 15:23:23.000000000 +0100
+++ src/gdb/interps.h	2005-10-17 15:29:40.000000000 +0100
@@ -76,5 +76,6 @@ extern void clear_interpreter_hooks (voi
 #define INTERP_MI3             "mi3"
 #define INTERP_MI		"mi"
 #define INTERP_TUI		"tui"
+#define INTERP_INSIGHT		"insight"
 
 #endif

             reply	other threads:[~2005-10-25 12:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-25 22:22 Andrew STUBBS [this message]
2005-11-04 22:36 ` Andrew STUBBS
2005-11-07  0:19   ` Jim Blandy
2005-11-07 15:04     ` Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=435E2756.8060103@st.com \
    --to=andrew.stubbs@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox