From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28267 invoked by alias); 25 Oct 2005 12:40:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28248 invoked by uid 22791); 25 Oct 2005 12:40:39 -0000 Received: from fra-del-01.spheriq.net (HELO fra-del-01.spheriq.net) (195.46.51.97) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 25 Oct 2005 12:40:39 +0000 Received: from fra-out-03.spheriq.net (fra-out-03.spheriq.net [195.46.51.131]) by fra-del-01.spheriq.net with ESMTP id j9PCebxB006306 for ; Tue, 25 Oct 2005 12:40:37 GMT Received: from fra-cus-01.spheriq.net (fra-cus-01.spheriq.net [195.46.51.37]) by fra-out-03.spheriq.net with ESMTP id j9PCeagw012164 for ; Tue, 25 Oct 2005 12:40:36 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by fra-cus-01.spheriq.net with ESMTP id j9PCeZw1011297 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=OK) for ; Tue, 25 Oct 2005 12:40:35 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 84AD9DA44 for ; Tue, 25 Oct 2005 12:40:30 +0000 (GMT) Received: by zeta.dmz-eu.st.com (STMicroelectronics, from userid 60012) id 1C47247389; Tue, 25 Oct 2005 12:43:19 +0000 (GMT) Received: from zeta.dmz-eu.st.com (localhost [127.0.0.1]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 7D510759B0 for ; Tue, 25 Oct 2005 12:43:18 +0000 (UTC) Received: from mail1.bri.st.com (mail1.bri.st.com [164.129.8.218]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 70FF847389 for ; Tue, 25 Oct 2005 12:43:17 +0000 (GMT) Received: from [164.129.15.13] (terrorhawk.bri.st.com [164.129.15.13]) by mail1.bri.st.com (MOS 3.5.8-GR) with ESMTP id CEB00710 (AUTH "andrew stubbs"); Tue, 25 Oct 2005 13:40:27 +0100 (BST) Message-ID: <435E2756.8060103@st.com> Date: Tue, 25 Oct 2005 22:22:00 -0000 From: Andrew STUBBS User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: PATCH: Fix -w option Content-Type: multipart/mixed; boundary="------------000300020403060807020009" X-O-Spoofed: Not Scanned X-O-General-Status: No X-O-Spam1-Status: Not Scanned X-O-Spam2-Status: Not Scanned X-O-URL-Status: Not Scanned X-O-Virus1-Status: No X-O-Virus2-Status: Not Scanned X-O-Virus3-Status: No X-O-Virus4-Status: No X-O-Virus5-Status: Not Scanned X-O-Image-Status: Not Scanned X-O-Attach-Status: Not Scanned X-SpheriQ-Ver: 4.1.07 X-SW-Source: 2005-10/txt/msg00200.txt.bz2 This is a multi-part message in MIME format. --------------000300020403060807020009 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 209 Hi, The -w option does not do anything anymore. The attached patch fixes the problem and allows it to open Insight once more. It also tidies up the use of interpreter_p a little wrt the tui. Andrew Stubbs --------------000300020403060807020009 Content-Type: text/plain; name="option_-w_fix.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="option_-w_fix.patch" Content-length: 1413 2005-10-25 Andrew Stubbs * main.c (main): Use INTERP_TUI instead of "tui". Set interpreter to INTERP_INSIGHT when '-w' given. * interps.h (INTERP_INSIGHT): New define. Index: src/gdb/main.c =================================================================== --- src.orig/gdb/main.c 2005-10-17 15:23:23.000000000 +0100 +++ src/gdb/main.c 2005-10-17 15:29:40.000000000 +0100 @@ -339,11 +339,16 @@ captured_main (void *data) case OPT_TUI: /* --tui is equivalent to -i=tui. */ xfree (interpreter_p); - interpreter_p = xstrdup ("tui"); + interpreter_p = xstrdup (INTERP_TUI); break; case OPT_WINDOWS: /* FIXME: cagney/2003-03-01: Not sure if this option is actually useful, and if it is, what it should do. */ +#ifdef GDBTK + /* --windows is equivalent to -i=insight. */ + xfree (interpreter_p); + interpreter_p = xstrdup (INTERP_INSIGHT); +#endif use_windows = 1; break; case OPT_NOWINDOWS: Index: src/gdb/interps.h =================================================================== --- src.orig/gdb/interps.h 2005-10-17 15:23:23.000000000 +0100 +++ src/gdb/interps.h 2005-10-17 15:29:40.000000000 +0100 @@ -76,5 +76,6 @@ extern void clear_interpreter_hooks (voi #define INTERP_MI3 "mi3" #define INTERP_MI "mi" #define INTERP_TUI "tui" +#define INTERP_INSIGHT "insight" #endif --------------000300020403060807020009--