Re: [review] Add gdb_compile_openmp to lib/gdb.exp

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2019-11-06 11:24 a.m., Pedro Alves (Code Review) wrote:
> Pedro Alves has posted comments on this change.
> 
> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503
> ......................................................................
> 
> 
> Patch Set 1:
> 
> (1 comment)
> 
> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp 
> File gdb/testsuite/lib/gdb.exp:
> 
> https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/503/1/gdb/testsuite/lib/gdb.exp@5961 
> PS1, Line 5961: 
> 5887 | proc build_executable_from_specs {testname executable options args} {
>      | ...
> 5956 | 	    lappend objects "${binfile}${i}.o"
> 5957 | 	    incr i
> 5958 | 	}
> 5959 | 	set ret [$func $objects "${binfile}" executable $options]
> 5960 |     }
> 5961 >     if  { $ret != "" } {
> 5962 |         untested $testname
> 5963 |         return -1
> 5964 |     }
> 5965 | 
> 5966 |     return 0
> 
>>> (I wanted to select all lines from 5930 to 5961 to show the whole context in the email notificatio […]
> 
> Nice, that worked!  I think it would be a good idea to mention this in our Gerrit wiki, to invite/remind people do this?

Sure!

(This is sent as an email to test replying to comments by email)