Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.org
Subject: Re: [RFA] Add some VAX floating point formats to floatformat.[ch]
Date: Mon, 22 Aug 2005 10:22:00 -0000	[thread overview]
Message-ID: <43098730.3060802@redhat.com> (raw)
In-Reply-To: <200508212153.j7LLrJXJ006901@elgar.sibelius.xs4all.nl>

Hi Mark,

> Index: include/ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* floatformat.h (enum floatformat_byteorders): Add
> 	floatformat_vax.
> 	(floatformat_vax_aingle, floatformat_vax_double): Declare.

No objections from binutils for this, although it is officially a GDB 
header file so make sure that you get agreement from them before 
committing your change.  One point though:

> +  /* VAX byte order.  */
> +  floatformat_vax

I think that having a more descriptive comment for the VAX byte order 
would be helpful.  eg describing the layout of 1.2345678e10 as is done 
with the other entries in this enum.

Cheers
   Nick


  reply	other threads:[~2005-08-22  7:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-21 21:59 Mark Kettenis
2005-08-22 10:22 ` Nick Clifton [this message]
2005-08-22 11:53   ` Mark Kettenis
2005-08-22 16:07     ` Nick Clifton
2005-08-22 16:26       ` Jan-Benedict Glaw
2005-08-22 18:32         ` Paul Koning
2005-08-22 18:40   ` DJ Delorie
2005-08-23 21:58 ` Ken Raeburn
2005-08-31  8:48   ` Mark Kettenis
2005-08-31 17:30     ` Jan-Benedict Glaw
     [not found]       ` <200508312142.j7VLgn8f019978@elgar.sibelius.xs4all.nl>
2005-11-02 10:20         ` Jan-Benedict Glaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43098730.3060802@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox