From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-40632-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 7015 invoked by alias); 22 Aug 2005 07:58:18 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6984 invoked by uid 22791); 22 Aug 2005 07:58:11 -0000
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 22 Aug 2005 07:58:11 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j7M7w9Ir026237;
	Mon, 22 Aug 2005 03:58:09 -0400
Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j7M7vwV29259;
	Mon, 22 Aug 2005 03:58:03 -0400
Received: from [172.31.0.98] (vpn-68-4.surrey.redhat.com [10.32.68.4])
	by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j7M7vv0l017308;
	Mon, 22 Aug 2005 08:57:57 +0100
Message-ID: <43098730.3060802@redhat.com>
Date: Mon, 22 Aug 2005 10:22:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Mark Kettenis <mark.kettenis@xs4all.nl>
CC: gdb-patches@sourceware.org, binutils@sourceware.org, gcc-patches@gcc.org
Subject: Re: [RFA] Add some VAX floating point formats to floatformat.[ch]
References: <200508212153.j7LLrJXJ006901@elgar.sibelius.xs4all.nl>
In-Reply-To: <200508212153.j7LLrJXJ006901@elgar.sibelius.xs4all.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-08/txt/msg00223.txt.bz2

Hi Mark,

> Index: include/ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* floatformat.h (enum floatformat_byteorders): Add
> 	floatformat_vax.
> 	(floatformat_vax_aingle, floatformat_vax_double): Declare.

No objections from binutils for this, although it is officially a GDB 
header file so make sure that you get agreement from them before 
committing your change.  One point though:

> +  /* VAX byte order.  */
> +  floatformat_vax

I think that having a more descriptive comment for the VAX byte order 
would be helpful.  eg describing the layout of 1.2345678e10 as is done 
with the other entries in this enum.

Cheers
   Nick