Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: gdb-patches@sources.redhat.com
Cc: chet.ramey@case.edu
Subject: Guidance re. MinGW and readline
Date: Mon, 18 Jul 2005 00:17:00 -0000	[thread overview]
Message-ID: <42DAF4FE.3060609@codesourcery.com> (raw)

Chet Ramey, the readline maintainer, has reviwed my patch for GDB here:

   http://sources.redhat.com/ml/gdb-patches/2005-06/msg00067.html

Chet has accepted the patch in principle, though he's decided to take a 
slightly different approach from the one that I did, modifying rltty.c 
to use conditional compilation to determine whether or not to use any of 
the various UNIX-ish terminal variants, rather than adding an entirely 
separate rlwin32tty.c file.  Chet's version (re-write?) of the patch 
will be in readline-5.1.

Chet has also decided that the (extremely minimal) Windows termcap 
functions that I provided (like "tputs" and "tgoto") should be included 
somewhere in the application, rather than in readline itself.

So, I think that there are two paths forward:

(1) Wait for readline-5.1 to be released, incorporate it into src/, and 
then to add the minimal termcap stuff to a file in gdb/ that is only 
used on MinGW.

(2) I backport Chet's changes to rltty.c to the src/readline/ 
sourcebase, and then proceed as above.  Because we know that these 
changes will be in readline-5.1, we needn't worry overmuch about 
divergence from upstread sources.

I'd prefer the second path, even though it's more work for me, in that 
it would hopefully result in more quickly reaching the state where all 
of the MinGW support is in the FSF GDB.  However, if the GDB maintainers 
don't want to go that route, I'll just wait.  I'd very much appreciate 
advice from the GDB maintainers about which path to take.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


             reply	other threads:[~2005-07-18  0:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-18  0:17 Mark Mitchell [this message]
2005-07-18  0:23 ` Daniel Jacobowitz
2005-07-18  1:01   ` Christopher Faylor
2005-07-18  3:23 ` Eli Zaretskii
2005-07-18  6:22 ` Mark Kettenis
2005-07-18 14:13   ` Mark Mitchell
2005-07-18 14:35   ` Christopher Faylor
2005-07-18 14:34     ` Mark Mitchell
2005-07-18 16:55     ` Ian Lance Taylor
2005-07-18 17:10       ` Christopher Faylor
2005-07-18 17:26         ` Ian Lance Taylor
2005-07-18 17:33           ` Daniel Jacobowitz
2005-07-18 17:47             ` Christopher Faylor
2005-07-18 17:59       ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42DAF4FE.3060609@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=chet.ramey@case.edu \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox