From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11058 invoked by alias); 18 Jul 2005 00:17:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11033 invoked by uid 22791); 18 Jul 2005 00:17:09 -0000 Received: from dumbledore.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.11) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 18 Jul 2005 00:17:09 +0000 Received: (qmail 10151 invoked from network); 18 Jul 2005 00:17:08 -0000 Received: from unknown (HELO ?10.253.176.54?) (mitchell@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Jul 2005 00:17:08 -0000 Message-ID: <42DAF4FE.3060609@codesourcery.com> Date: Mon, 18 Jul 2005 00:17:00 -0000 From: Mark Mitchell User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: gdb-patches@sources.redhat.com CC: chet.ramey@case.edu Subject: Guidance re. MinGW and readline Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-07/txt/msg00139.txt.bz2 Chet Ramey, the readline maintainer, has reviwed my patch for GDB here: http://sources.redhat.com/ml/gdb-patches/2005-06/msg00067.html Chet has accepted the patch in principle, though he's decided to take a slightly different approach from the one that I did, modifying rltty.c to use conditional compilation to determine whether or not to use any of the various UNIX-ish terminal variants, rather than adding an entirely separate rlwin32tty.c file. Chet's version (re-write?) of the patch will be in readline-5.1. Chet has also decided that the (extremely minimal) Windows termcap functions that I provided (like "tputs" and "tgoto") should be included somewhere in the application, rather than in readline itself. So, I think that there are two paths forward: (1) Wait for readline-5.1 to be released, incorporate it into src/, and then to add the minimal termcap stuff to a file in gdb/ that is only used on MinGW. (2) I backport Chet's changes to rltty.c to the src/readline/ sourcebase, and then proceed as above. Because we know that these changes will be in readline-5.1, we needn't worry overmuch about divergence from upstread sources. I'd prefer the second path, even though it's more work for me, in that it would hopefully result in more quickly reaching the state where all of the MinGW support is in the FSF GDB. However, if the GDB maintainers don't want to go that route, I'll just wait. I'd very much appreciate advice from the GDB maintainers about which path to take. Thanks, -- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304