Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Mitchell <mark@codesourcery.com>
To: chet.ramey@case.edu
Cc: Daniel Jacobowitz <drow@false.org>, Eli Zaretskii <eliz@gnu.org>,
	 bug-readline@gnu.org,  gdb-patches@sources.redhat.com
Subject: Re: PATCH: Readline on MinGW
Date: Fri, 29 Apr 2005 00:44:00 -0000	[thread overview]
Message-ID: <42718368.6030101@codesourcery.com> (raw)
In-Reply-To: <42714EFC.9020500@case.edu>

Chet Ramey wrote:
>>Eli, just to be clear, you said you "support" the patches I posted (with
>>this exception).  I'm interpreting that as "I hope they go into upstream
>>readline", rather than as "it's OK to check these patches into the GDB
>>repository."  If you actually meant the latter, let me know. :-)
> 
> 
> I only looked at the changes briefly, but they looked fine.  I would
> not, in any case, replace `kill' with `raise' without an autoconf test.

OK.  I'll add an autoconf test for "kill" and then use "raise" only if 
"kill" is unavailable.  I'll repost with that change soon.

> Unless there's something fatally wrong with the patch, I don't have a
> problem incorporating it into the readline distribution.

Great, thank you!

Eli, et. al., does that mean that it's OK to check the patch into GDB 
now?  What procedure do we use from here?

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


  reply	other threads:[~2005-04-29  0:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-28  6:53 Mark Mitchell
2005-04-28 20:09 ` Eli Zaretskii
2005-04-28 20:12   ` Daniel Jacobowitz
2005-04-28 20:45     ` Mark Mitchell
2005-04-28 21:02       ` Chet Ramey
2005-04-29  0:44         ` Mark Mitchell [this message]
2005-04-29  7:31           ` Eli Zaretskii
2005-04-29 16:10             ` Christopher Faylor
2005-04-29  1:51         ` Mark Mitchell
2005-04-28 21:02       ` Eli Zaretskii
2005-04-28 20:50     ` Eli Zaretskii
2005-04-28 21:17       ` Daniel Jacobowitz
2005-04-28 22:13         ` Andreas Schwab
2005-04-29  6:59         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42718368.6030101@codesourcery.com \
    --to=mark@codesourcery.com \
    --cc=bug-readline@gnu.org \
    --cc=chet.ramey@case.edu \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox