From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6709 invoked by alias); 29 Apr 2005 00:44:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6525 invoked from network); 29 Apr 2005 00:44:32 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 29 Apr 2005 00:44:32 -0000 Received: (qmail 4875 invoked from network); 29 Apr 2005 00:44:31 -0000 Received: from localhost (HELO ?10.253.209.104?) (mitchell@127.0.0.1) by mail.codesourcery.com with SMTP; 29 Apr 2005 00:44:31 -0000 Message-ID: <42718368.6030101@codesourcery.com> Date: Fri, 29 Apr 2005 00:44:00 -0000 From: Mark Mitchell User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: chet.ramey@case.edu CC: Daniel Jacobowitz , Eli Zaretskii , bug-readline@gnu.org, gdb-patches@sources.redhat.com Subject: Re: PATCH: Readline on MinGW References: <4270886B.1020806@codesourcery.com> <01c54c2d$Blat.v2.4$f3029840@zahav.net.il> <20050428201215.GA14846@nevyn.them.org> <42714B6F.1030009@codesourcery.com> <42714EFC.9020500@case.edu> In-Reply-To: <42714EFC.9020500@case.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-04/txt/msg00412.txt.bz2 Chet Ramey wrote: >>Eli, just to be clear, you said you "support" the patches I posted (with >>this exception). I'm interpreting that as "I hope they go into upstream >>readline", rather than as "it's OK to check these patches into the GDB >>repository." If you actually meant the latter, let me know. :-) > > > I only looked at the changes briefly, but they looked fine. I would > not, in any case, replace `kill' with `raise' without an autoconf test. OK. I'll add an autoconf test for "kill" and then use "raise" only if "kill" is unavailable. I'll repost with that change soon. > Unless there's something fatally wrong with the patch, I don't have a > problem incorporating it into the readline distribution. Great, thank you! Eli, et. al., does that mean that it's OK to check the patch into GDB now? What procedure do we use from here? Thanks, -- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304