From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Match shell_prompt # in batch-preserve-term-settings.exp
Date: Wed, 18 May 2016 11:27:00 -0000 [thread overview]
Message-ID: <4264add0-f316-5b8a-8df6-fdf15bea6b39@redhat.com> (raw)
In-Reply-To: <1462877837-31075-1-git-send-email-yao.qi@linaro.org>
On 05/10/2016 11:57 AM, Yao Qi wrote:
> batch-preserve-term-settings.exp fails if the shell prompt isn't $. It
> is # in our testing env. In fact, the shell prompt can be anything.
>
> The perfect solution would be "set_board_info shell_prompt" in the
> host board file, and use board_info shell_prompt in
> batch-preserve-term-settings.exp. This is a little bit overkill to
> me, and we still need to figure out the different prompts on different
> shells. I also tried to start shell with the prompt preset, but there is
> not unique way to set shell prompt in different shells, so I give up.
Yeah, I think that'd be overkill. Anyone running tests with a custom
prompt can just not do that.
> It is reasonably simple to match either $ or # for the shell prompt, and
> we can easily extend it to match other char, like >.
Excepting "#" is reasonable, since it'll be the usual prompt if
you run the shell as root.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-05-18 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 10:57 Yao Qi
2016-05-10 11:25 ` Andreas Schwab
2016-05-10 12:02 ` Yao Qi
2016-05-16 16:34 ` Yao Qi
2016-05-18 11:27 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4264add0-f316-5b8a-8df6-fdf15bea6b39@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox