From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81434 invoked by alias); 18 May 2016 11:27:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81423 invoked by uid 89); 18 May 2016 11:27:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=our, perfect X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 May 2016 11:27:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8639868AA; Wed, 18 May 2016 11:27:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4IBRLKC020388; Wed, 18 May 2016 07:27:21 -0400 Subject: Re: [PATCH] Match shell_prompt # in batch-preserve-term-settings.exp To: Yao Qi , gdb-patches@sourceware.org References: <1462877837-31075-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <4264add0-f316-5b8a-8df6-fdf15bea6b39@redhat.com> Date: Wed, 18 May 2016 11:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1462877837-31075-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00292.txt.bz2 On 05/10/2016 11:57 AM, Yao Qi wrote: > batch-preserve-term-settings.exp fails if the shell prompt isn't $. It > is # in our testing env. In fact, the shell prompt can be anything. > > The perfect solution would be "set_board_info shell_prompt" in the > host board file, and use board_info shell_prompt in > batch-preserve-term-settings.exp. This is a little bit overkill to > me, and we still need to figure out the different prompts on different > shells. I also tried to start shell with the prompt preset, but there is > not unique way to set shell prompt in different shells, so I give up. Yeah, I think that'd be overkill. Anyone running tests with a custom prompt can just not do that. > It is reasonably simple to match either $ or # for the shell prompt, and > we can easily extend it to match other char, like >. Excepting "#" is reasonable, since it'll be the usual prompt if you run the shell as root. Thanks, Pedro Alves