Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA:] Support lstat as simulator call.
Date: Sun, 12 Dec 2004 18:04:00 -0000	[thread overview]
Message-ID: <41BC8732.7040102@gnu.org> (raw)
In-Reply-To: <200412070243.iB72hvwe017892@ignucius.se.axis.com>

Hans-Peter Nilsson wrote:
>>Date: Tue, 7 Dec 2004 02:43:16 +0100
>>From: Hans-Peter Nilsson <hp@axis.com>

Yes (with tweak) and thanks for testing this.

  callback.c	3 Dec 2004 23:34:55 -0000	1.12
>>--- callback.c	6 Dec 2004 17:10:25 -0000
>>*************** os_fstat (p, fd, buf)
>>*** 407,412 ****
>>--- 407,422 ----
>>    return wrap (p, fstat (fdmap (p, fd), buf));
>>  }
>>  
>>+ static int
>>+ os_lstat (p, file, buf)
>>+      host_callback *p;
>>+      const char *file;
>>+      struct stat *buf;
>>+ {
>>+   /* ??? Same issue here as with os_fstat.  */

Use /* FIXME: hpn/2004-12-12: ... */ or /* NOTE: hph/2004-12-12: ... */ 
so we know who and when the comment was added.

therwize, yes, ok,
Andrew

>>+   return (p, lstat (file, buf));
> 
> 
> Oops should have been "return wrap (p, lstat (file, buf));"
> Sorry about that.
> 
> (Noticed because of a error-checking test-case that didn't show
> up as KPASS...  The local equivalent had sysroot stuff here so
> the code was slightly edited from the well-tested variant.)
> 
> brgds, H-P
> 


      reply	other threads:[~2004-12-12 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-07  2:29 Hans-Peter Nilsson
2004-12-07  3:22 ` Hans-Peter Nilsson
2004-12-12 18:04   ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41BC8732.7040102@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hans-peter.nilsson@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox