From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22014 invoked by alias); 12 Dec 2004 18:02:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21420 invoked from network); 12 Dec 2004 18:02:39 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 12 Dec 2004 18:02:39 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBCI2N74009337 for ; Sun, 12 Dec 2004 13:02:29 -0500 Received: from localhost.redhat.com (vpn50-50.rdu.redhat.com [172.16.50.50]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBCI2Nr22790; Sun, 12 Dec 2004 13:02:23 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9DF4D3EF9; Sun, 12 Dec 2004 13:00:19 -0500 (EST) Message-ID: <41BC8732.7040102@gnu.org> Date: Sun, 12 Dec 2004 18:04:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Hans-Peter Nilsson Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA:] Support lstat as simulator call. References: <200412070243.iB72hvwe017892@ignucius.se.axis.com> In-Reply-To: <200412070243.iB72hvwe017892@ignucius.se.axis.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-12/txt/msg00336.txt.bz2 Hans-Peter Nilsson wrote: >>Date: Tue, 7 Dec 2004 02:43:16 +0100 >>From: Hans-Peter Nilsson Yes (with tweak) and thanks for testing this. callback.c 3 Dec 2004 23:34:55 -0000 1.12 >>--- callback.c 6 Dec 2004 17:10:25 -0000 >>*************** os_fstat (p, fd, buf) >>*** 407,412 **** >>--- 407,422 ---- >> return wrap (p, fstat (fdmap (p, fd), buf)); >> } >> >>+ static int >>+ os_lstat (p, file, buf) >>+ host_callback *p; >>+ const char *file; >>+ struct stat *buf; >>+ { >>+ /* ??? Same issue here as with os_fstat. */ Use /* FIXME: hpn/2004-12-12: ... */ or /* NOTE: hph/2004-12-12: ... */ so we know who and when the comment was added. therwize, yes, ok, Andrew >>+ return (p, lstat (file, buf)); > > > Oops should have been "return wrap (p, lstat (file, buf));" > Sorry about that. > > (Noticed because of a error-checking test-case that didn't show > up as KPASS... The local equivalent had sysroot stuff here so > the code was slightly edited from the well-tested variant.) > > brgds, H-P >