From: Andrew Cagney <cagney@gnu.org>
To: Richard Earnshaw <Richard.Earnshaw@buzzard.freeserve.co.uk>
Cc: gdb-patches@sources.redhat.com,
Michael Chastain <mec.gnu@mindspring.com>
Subject: Re: [PATCH] testsuite/config/sim.exp:gdb_load fix return values
Date: Sun, 28 Nov 2004 17:36:00 -0000 [thread overview]
Message-ID: <41AA0C4B.3020706@gnu.org> (raw)
In-Reply-To: <200411271303.iARD32Ie003284@merlin.buzzard.freeserve.co.uk>
Richard Earnshaw wrote:
> This patch fixes the return values of the gdb_load implementation in
> sim.exp. With this patch the testsuite is begining to look somewhat more
> sane again for an arm-elf cross.
>
> OK?
>
> * config/sim.exp (gdb_load): Return 0 on success, -1 on failure.
M'kay (for michael).
Andrew
> ------------------------------------------------------------------------
>
> Index: sim.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/config/sim.exp,v
> retrieving revision 1.2
> diff -p -p -r1.2 sim.exp
> *** sim.exp 8 Feb 2004 03:56:14 -0000 1.2
> --- sim.exp 27 Nov 2004 12:59:44 -0000
> *************** proc gdb_load { arg } {
> *** 71,77 ****
> }
> set timeout 30
> verbose "Timeout is now $timeout seconds" 2
> ! return 1
> }
> -re "$gdb_prompt $" {
> if $verbose>1 then {
> --- 71,77 ----
> }
> set timeout 30
> verbose "Timeout is now $timeout seconds" 2
> ! return 0
> }
> -re "$gdb_prompt $" {
> if $verbose>1 then {
> *************** proc gdb_load { arg } {
> *** 84,87 ****
> --- 84,88 ----
> }
> }
> }
> + return -1
> }
prev parent reply other threads:[~2004-11-28 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-27 13:09 Richard Earnshaw
2004-11-28 17:36 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41AA0C4B.3020706@gnu.org \
--to=cagney@gnu.org \
--cc=Richard.Earnshaw@buzzard.freeserve.co.uk \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox