From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-37113-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 21759 invoked by alias); 28 Nov 2004 17:36:01 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 21747 invoked from network); 28 Nov 2004 17:35:59 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 28 Nov 2004 17:35:59 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iASHZrEk021992
	for <gdb-patches@sources.redhat.com>; Sun, 28 Nov 2004 12:35:54 -0500
Received: from localhost.redhat.com (vpn50-27.rdu.redhat.com [172.16.50.27])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iASHZqr11699;
	Sun, 28 Nov 2004 12:35:52 -0500
Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP id 41EFA129D8C;
	Sun, 28 Nov 2004 12:35:08 -0500 (EST)
Message-ID: <41AA0C4B.3020706@gnu.org>
Date: Sun, 28 Nov 2004 17:36:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla Thunderbird 0.8 (X11/20041020)
MIME-Version: 1.0
To: Richard Earnshaw <Richard.Earnshaw@buzzard.freeserve.co.uk>
Cc: gdb-patches@sources.redhat.com, Michael Chastain <mec.gnu@mindspring.com>
Subject: Re: [PATCH] testsuite/config/sim.exp:gdb_load fix return values
References: <200411271303.iARD32Ie003284@merlin.buzzard.freeserve.co.uk>
In-Reply-To: <200411271303.iARD32Ie003284@merlin.buzzard.freeserve.co.uk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-11/txt/msg00487.txt.bz2

Richard Earnshaw wrote:
> This patch fixes the return values of the gdb_load implementation in 
> sim.exp.  With this patch the testsuite is begining to look somewhat more 
> sane again for an arm-elf cross.
> 
> OK?
> 
> 	* config/sim.exp (gdb_load): Return 0 on success, -1 on failure.

M'kay (for michael).

Andrew

> ------------------------------------------------------------------------
> 
> Index: sim.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/config/sim.exp,v
> retrieving revision 1.2
> diff -p -p -r1.2 sim.exp
> *** sim.exp	8 Feb 2004 03:56:14 -0000	1.2
> --- sim.exp	27 Nov 2004 12:59:44 -0000
> *************** proc gdb_load { arg } {
> *** 71,77 ****
>   	    }
>   	    set timeout 30
>   	    verbose "Timeout is now $timeout seconds" 2
> ! 	    return 1
>   	}
>   	-re "$gdb_prompt $"     {
>   	    if $verbose>1 then {
> --- 71,77 ----
>   	    }
>   	    set timeout 30
>   	    verbose "Timeout is now $timeout seconds" 2
> ! 	    return 0
>   	}
>   	-re "$gdb_prompt $"     {
>   	    if $verbose>1 then {
> *************** proc gdb_load { arg } {
> *** 84,87 ****
> --- 84,88 ----
>   	    }
>   	}
>       }
> +     return -1
>   }