Re: [RFA]: test for backtrace failures in macro

[Jeff Johnston <jjohnstn@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

Jeff Johnston wrote:
> Andrew Cagney wrote:
> 
>> Jeff Johnston wrote:
>>
>>> The following is a test for the change I recently made to allow 
>>> macros to continue operating even after a backtrace failure occurs.
>>>
>>> Tested on x86-linux with linuxthreads and ia64-linux with nptl threads.
>>
>>
>>
>> Can you think of an alternative to "macro" as the prefix?  "macro" can 
>> also refer to:
>>
>>     #define MACRO
>>
>> (If I new of one, I'd suggest it :-)  With a better name, ok.
>>
> 
> Will rename to threadapply.exp and threadapply.c
> 
> -- Jeff J.
>

The following has been checked in.  Tested on old x86-linux with linuxthreads 
and RHEL3 x86-linux.

-- Jeff J.

2004-11-11  Jeff Johnston  <jjohnstn@redhat.com>

         * gdb.threads/threadapply.exp: New test.
         * gdb.threads/threadapply.c: New file.




[-- Attachment #2: backtracetest.patch2 --]
[-- Type: text/plain, Size: 5032 bytes --]

Index: gdb.threads/threadapply.c
===================================================================
RCS file: gdb.threads/threadapply.c
diff -N gdb.threads/threadapply.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gdb.threads/threadapply.c	11 Nov 2004 21:35:44 -0000
@@ -0,0 +1,82 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2002, 2003, 2004 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 2 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 59 Temple Place - Suite 330,
+   Boston, MA 02111-1307, USA.  
+ 
+   This file is copied from schedlock.c.  */
+
+#include <stdio.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <pthread.h>
+
+void *thread_function(void *arg); /* Pointer to function executed by each thread */
+
+#define NUM 5
+
+unsigned int args[NUM+1];
+
+int main() {
+    int res;
+    int all_started;
+    pthread_t threads[NUM];
+    void *thread_result;
+    long i;
+
+    for (i = 0; i < NUM; i++)
+      {
+	args[i] = 1; /* Init value.  */
+	res = pthread_create(&threads[i],
+		             NULL,
+			     thread_function,
+			     (void *) i);
+      }
+
+    all_started = 0;
+    while (!all_started)
+      {
+	all_started = 1;
+        for (i = 0; i < NUM; i++)
+          {
+            if (args[i] == 1)
+	      {
+	        all_started = 0;
+	        break;
+	      }
+          }  
+      }
+	
+    args[i] = 1;
+    /* Break here */
+    thread_function ((void *) i);
+
+    exit(EXIT_SUCCESS);
+}
+
+void *thread_function(void *arg) {
+    int my_number =  (long) arg;
+    int *myp = (int *) &args[my_number];
+
+    /* Don't run forever.  Run just short of it :)  */
+    while (*myp > 0)
+      {
+	(*myp) ++;  /* Loop increment.  */
+      }
+
+    pthread_exit(NULL);
+}
+
Index: gdb.threads/threadapply.exp
===================================================================
RCS file: gdb.threads/threadapply.exp
diff -N gdb.threads/threadapply.exp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gdb.threads/threadapply.exp	11 Nov 2004 21:35:44 -0000
@@ -0,0 +1,71 @@
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2004 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  
+
+if $tracelevel {
+    strace $tracelevel
+}
+
+set prms_id 0
+set bug_id 0
+
+# This test verifies that a macro using backtrace can be applied to all threads
+# and will continue for each thread even though an error may occur in
+# backtracing one of the threads.
+
+set testfile "threadapply"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable [list debug "incdir=${objdir}"]] != "" } {
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+#
+# Run to `main' where we begin our tests.
+#
+
+if ![runto_main] then {
+    gdb_suppress_tests
+}
+
+# Break after all threads have been started.
+set break_line [gdb_get_line_number "Break here"]
+gdb_test "b $break_line" ""
+gdb_test "continue"
+
+gdb_test_multiple "define backthread" "defining macro" {
+  -re "Type commands for definition of \"backthread\".\r\nEnd with a line saying just \"end\".\r\n>$" {
+    gdb_test_multiple "bt\np\/x 20\nend\n" "macro details" {
+      -re "$gdb_prompt $" {
+        pass "macro details"
+      }
+    }
+    pass "defining macro"
+  }
+}
+
+# Cause backtraces to fail by setting a limit.  This allows us to
+# verify that the macro can get past the backtrace error and perform
+# subsequent commands.
+gdb_test "set backtrace limit 3" ""
+gdb_test "thread apply all backthread" "Thread ..*\\\$1 = 0x14.*Thread ..*\\\$2 = 0x14.*Thread ..*\\\$3 = 0x14.*Thread ..*\\\$4 = 0x14.*Thread ..*\\\$5 = 0x14.*Thread ..*\\\$. = 0x14"
+