Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: jbeniston@compxs.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix for PR/1806
Date: Thu, 11 Nov 2004 17:05:00 -0000	[thread overview]
Message-ID: <41939B94.6060106@gnu.org> (raw)
In-Reply-To: <001201c4c34d$8f764f10$0bbda8c0@Kindrogan>

Jon Beniston wrote:
> Hi,
> 
> The following patch should fix PR/1806. If good, can someone commit it
> please?

I've checked this in.
(I've also sent Jon assignment paperwork).

Andrew

> 2004-11-05  Jon Beniston <jon@beniston.com>
> 
> 	* remote.c (putpkt_binary) Fix PR gdb/1806. Send an ACK 
> 	when an unexpected packet is received, as the target stubs 
> 	continually retransmit the same packet until ACKed.
> 	
> 
> diff -c -p -r1.152 remote.c
> *** remote.c    27 Oct 2004 20:03:50 -0000      1.152
> --- remote.c    5 Nov 2004 15:30:34 -0000
> *************** putpkt_binary (char *buf, int cnt)
> *** 3972,3980 ****
>               {
>                 if (remote_debug)
>                   fprintf_unfiltered (gdb_stdlog, "Packet instead of Ack,
> ignoring it\n");
> !               /* It's probably an old response, and we're out of sync.
> !                  Just gobble up the packet and ignore it.  */
>                 read_frame (junkbuf, sizeof_junkbuf);
>                 continue;       /* Now, go look for + */
>               }
>             default:
> --- 3972,3982 ----
>               {
>                 if (remote_debug)
>                   fprintf_unfiltered (gdb_stdlog, "Packet instead of Ack,
> ignoring it\n");
> !               /* It's probably an old response sent because an ACK was
> lost.
> !                  Gobble up the packet and ack it so it doesn't get
> !                  retransmitted when we resend this packet.  */
>                 read_frame (junkbuf, sizeof_junkbuf);
> +               serial_write (remote_desc, "+", 1);
>                 continue;       /* Now, go look for + */
>               }
>             default:
> 
> 
> 


      reply	other threads:[~2004-11-11 17:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-05 15:39 Jon Beniston
2004-11-11 17:05 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41939B94.6060106@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jbeniston@compxs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox