From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31838 invoked by alias); 11 Nov 2004 17:05:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31789 invoked from network); 11 Nov 2004 17:05:41 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 11 Nov 2004 17:05:41 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iABH5aMp011581 for ; Thu, 11 Nov 2004 12:05:41 -0500 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iABH5Ur10285; Thu, 11 Nov 2004 12:05:30 -0500 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id CA59A129D8C; Thu, 11 Nov 2004 12:04:21 -0500 (EST) Message-ID: <41939B94.6060106@gnu.org> Date: Thu, 11 Nov 2004 17:05:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: jbeniston@compxs.com Cc: gdb-patches@sources.redhat.com Subject: Re: Fix for PR/1806 References: <001201c4c34d$8f764f10$0bbda8c0@Kindrogan> In-Reply-To: <001201c4c34d$8f764f10$0bbda8c0@Kindrogan> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00235.txt.bz2 Jon Beniston wrote: > Hi, > > The following patch should fix PR/1806. If good, can someone commit it > please? I've checked this in. (I've also sent Jon assignment paperwork). Andrew > 2004-11-05 Jon Beniston > > * remote.c (putpkt_binary) Fix PR gdb/1806. Send an ACK > when an unexpected packet is received, as the target stubs > continually retransmit the same packet until ACKed. > > > diff -c -p -r1.152 remote.c > *** remote.c 27 Oct 2004 20:03:50 -0000 1.152 > --- remote.c 5 Nov 2004 15:30:34 -0000 > *************** putpkt_binary (char *buf, int cnt) > *** 3972,3980 **** > { > if (remote_debug) > fprintf_unfiltered (gdb_stdlog, "Packet instead of Ack, > ignoring it\n"); > ! /* It's probably an old response, and we're out of sync. > ! Just gobble up the packet and ignore it. */ > read_frame (junkbuf, sizeof_junkbuf); > continue; /* Now, go look for + */ > } > default: > --- 3972,3982 ---- > { > if (remote_debug) > fprintf_unfiltered (gdb_stdlog, "Packet instead of Ack, > ignoring it\n"); > ! /* It's probably an old response sent because an ACK was > lost. > ! Gobble up the packet and ack it so it doesn't get > ! retransmitted when we resend this packet. */ > read_frame (junkbuf, sizeof_junkbuf); > + serial_write (remote_desc, "+", 1); > continue; /* Now, go look for + */ > } > default: > > >