From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, gdb, ARM] Use getters/setters to access ARM branch type
Date: Tue, 10 May 2016 15:32:00 -0000 [thread overview]
Message-ID: <41808308.gilpfryNrk@e108577-lin> (raw)
In-Reply-To: <86eg9adk20.fsf@gmail.com>
On Tuesday 10 May 2016 16:11:51 Yao Qi wrote:
> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
> > @@ -8467,7 +8467,8 @@ coff_sym_is_thumb (int val)
> >
> > static void
> > arm_elf_make_msymbol_special(asymbol *sym, struct minimal_symbol *msym)
> > {
> >
> > - if (ARM_SYM_BRANCH_TYPE (&((elf_symbol_type *)sym)->internal_elf_sym)
> > + elf_symbol_type *elfsym = (elf_symbol_type *) sym;
>
> We need a blank line here.
>
> > + if (ARM_GET_SYM_BRANCH_TYPE
> > (elfsym->internal_elf_sym.st_target_internal)>
> > == ST_BRANCH_TO_THUMB)
> >
> > MSYMBOL_SET_SPECIAL (msym);
>
> Patch is OK to me.
Committed with the above changes.
Thanks. Best regards,
Thomas
prev parent reply other threads:[~2016-05-10 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 14:40 Thomas Preudhomme
2016-05-10 15:12 ` Yao Qi
2016-05-10 15:32 ` Thomas Preudhomme [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41808308.gilpfryNrk@e108577-lin \
--to=thomas.preudhomme@foss.arm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox