From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131468-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1722 invoked by alias); 10 May 2016 15:32:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 1711 invoked by uid 89); 10 May 2016 15:32:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=BAYES_05,KAM_LAZY_DOMAIN_SECURITY,KAM_STOCKGEN,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=sk:ARM_SYM, sk:arm_elf, sk:ST_BRAN, sk:st_bran
X-HELO: foss.arm.com
Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 May 2016 15:32:15 +0000
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91EC949;	Tue, 10 May 2016 08:32:25 -0700 (PDT)
Received: from e108577-lin.localnet (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249])	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EEF1E3F218;	Tue, 10 May 2016 08:32:13 -0700 (PDT)
From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH, gdb, ARM] Use getters/setters to access ARM branch type
Date: Tue, 10 May 2016 15:32:00 -0000
Message-ID: <41808308.gilpfryNrk@e108577-lin>
User-Agent: KMail/4.13.3 (Linux/3.13.0-85-generic; KDE/4.13.3; x86_64; ; )
In-Reply-To: <86eg9adk20.fsf@gmail.com>
References: <3219422.otqiV2U3aN@e108577-lin> <86eg9adk20.fsf@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
X-SW-Source: 2016-05/txt/msg00174.txt.bz2

On Tuesday 10 May 2016 16:11:51 Yao Qi wrote:
> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
> > @@ -8467,7 +8467,8 @@ coff_sym_is_thumb (int val)
> > 
> >  static void
> >  arm_elf_make_msymbol_special(asymbol *sym, struct minimal_symbol *msym)
> >  {
> > 
> > -  if (ARM_SYM_BRANCH_TYPE (&((elf_symbol_type *)sym)->internal_elf_sym)
> > +  elf_symbol_type *elfsym = (elf_symbol_type *) sym;
> 
> We need a blank line here.
> 
> > +  if (ARM_GET_SYM_BRANCH_TYPE
> > (elfsym->internal_elf_sym.st_target_internal)> 
> >        == ST_BRANCH_TO_THUMB)
> >      
> >      MSYMBOL_SET_SPECIAL (msym);
> 
> Patch is OK to me.

Committed with the above changes.

Thanks. Best regards,

Thomas