Re: [PATCH/RFA] Add some constants in mips-tdep.h

[Andrew Cagney <cagney@gnu.org>]

Mark Kettenis wrote:
>    Date: Sun, 24 Oct 2004 17:18:59 +0200 (CEST)
>    From: mark Kettenis <kettenis@gnu.org>
> 
>    Hi Andrew,
> 
>    This adds some symbolic constants to mips-tdep.h that I'd like to use
>    to implement OpenBSD/mips64 signal trampoline support.
> 
>    OK?
> 
> Argh!  I shouldn't make any last-minute changes just to make it easier
> to add a proper ChangeLog entry.

M'kay.

> Here's a better patch.  It even compiler ;-).
> 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* mips-tdep.h: Add MIPS_ZERO_REGNUM, MIPS_AT_REGNUM and
> 	MIPS_RA_REGNUM to enum with register numbers.
> 	(enum mips_insn_size): New enum.
> 
> Index: mips-tdep.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.h,v
> retrieving revision 1.8
> diff -u -p -r1.8 mips-tdep.h
> --- mips-tdep.h 22 Jun 2004 00:01:04 -0000 1.8
> +++ mips-tdep.h 24 Oct 2004 15:22:52 -0000
> @@ -61,8 +61,12 @@ struct mips_regnum
>  };
>  extern const struct mips_regnum *mips_regnum (struct gdbarch *gdbarch);
>  
> -enum {
> +enum
> +{
> +  MIPS_ZERO_REGNUM = 0,
> +  MIPS_AT_REGNUM = 1,
>    MIPS_SP_REGNUM = 29,
> +  MIPS_RA_REGNUM = 31,
>    MIPS_EMBED_LO_REGNUM = 33,
>    MIPS_EMBED_HI_REGNUM = 34,
>    MIPS_EMBED_BADVADDR_REGNUM = 35,
> @@ -74,5 +78,11 @@ enum {
>  /* Defined in mips-tdep.c and used in remote-mips.c */
>  extern void deprecated_mips_set_processor_regs_hack (void);
>  
> +/* Instruction sizes.  */
> +enum mips_insn_size
> +{
> +  MIPS16_INSN_SIZE = 2,
> +  MIPS32_INSN_SIZE = 4
> +};
>  
>  #endif /* MIPS_TDEP_H */
>