From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 623 invoked by alias); 26 Oct 2004 00:41:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 613 invoked from network); 26 Oct 2004 00:41:29 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 26 Oct 2004 00:41:29 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id i9Q0fOlN005397 for ; Mon, 25 Oct 2004 20:41:29 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9Q0fOr26355; Mon, 25 Oct 2004 20:41:24 -0400 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E58FA1294B5; Mon, 25 Oct 2004 20:40:13 -0400 (EDT) Message-ID: <417D9CEA.2090104@gnu.org> Date: Tue, 26 Oct 2004 00:41:00 -0000 From: Andrew Cagney User-Agent: Mozilla Thunderbird 0.8 (X11/20041020) MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Add some constants in mips-tdep.h References: <200410241518.i9OFIx4t027387@elgar.sibelius.xs4all.nl> <200410241525.i9OFPj2r027411@elgar.sibelius.xs4all.nl> In-Reply-To: <200410241525.i9OFPj2r027411@elgar.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00427.txt.bz2 Mark Kettenis wrote: > Date: Sun, 24 Oct 2004 17:18:59 +0200 (CEST) > From: mark Kettenis > > Hi Andrew, > > This adds some symbolic constants to mips-tdep.h that I'd like to use > to implement OpenBSD/mips64 signal trampoline support. > > OK? > > Argh! I shouldn't make any last-minute changes just to make it easier > to add a proper ChangeLog entry. M'kay. > Here's a better patch. It even compiler ;-). > > Index: ChangeLog > from Mark Kettenis > > * mips-tdep.h: Add MIPS_ZERO_REGNUM, MIPS_AT_REGNUM and > MIPS_RA_REGNUM to enum with register numbers. > (enum mips_insn_size): New enum. > > Index: mips-tdep.h > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.h,v > retrieving revision 1.8 > diff -u -p -r1.8 mips-tdep.h > --- mips-tdep.h 22 Jun 2004 00:01:04 -0000 1.8 > +++ mips-tdep.h 24 Oct 2004 15:22:52 -0000 > @@ -61,8 +61,12 @@ struct mips_regnum > }; > extern const struct mips_regnum *mips_regnum (struct gdbarch *gdbarch); > > -enum { > +enum > +{ > + MIPS_ZERO_REGNUM = 0, > + MIPS_AT_REGNUM = 1, > MIPS_SP_REGNUM = 29, > + MIPS_RA_REGNUM = 31, > MIPS_EMBED_LO_REGNUM = 33, > MIPS_EMBED_HI_REGNUM = 34, > MIPS_EMBED_BADVADDR_REGNUM = 35, > @@ -74,5 +78,11 @@ enum { > /* Defined in mips-tdep.c and used in remote-mips.c */ > extern void deprecated_mips_set_processor_regs_hack (void); > > +/* Instruction sizes. */ > +enum mips_insn_size > +{ > + MIPS16_INSN_SIZE = 2, > + MIPS32_INSN_SIZE = 4 > +}; > > #endif /* MIPS_TDEP_H */ >