Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Chastain <mec.gnu@mindspring.com>
To: kettenis@gnu.org, cagney@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [COMMIT] Accept "\r\n" line-endings on all hosts
Date: Fri, 15 Oct 2004 02:16:00 -0000	[thread overview]
Message-ID: <416F32E7.nail3XL2STGUE@mindspring.com> (raw)
In-Reply-To: <200410141948.i9EJmirp001178@elgar.sibelius.xs4all.nl>

Hi Mark,

A good idea, but a few corrections please.  

  # Please email any bugs, comments, and/or additions to this file to:
  # bug-gdb@gnu.org

    Drop this part.

  set file [open "crlf.gdb" "w"]
  puts -nonewline $file "info break\r\n"
  close $file

    Usually I would prefer to have crlf.gdb be a static file.
    In view of the critical nature of the "\r\n" part, I agree with
    Andrew's analysis, doing this in TCL is safer than relying on
    cvs to preserve the line endings.

    But it needs error checking on the statements with external
    effect, especially "open".

  remote_file build delete "crlf.gdb"
  remote_file host delete $cmdfile

    Drop these.  It's good to leave small files lying around after a
    test -- makes it easier to debug if anything goes wrong.

	* gdb.base/crlf.exp: New file.

Michael


  parent reply	other threads:[~2004-10-15  2:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-14 12:44 Mark Kettenis
2004-10-14 13:47 ` Andrew Cagney
2004-10-14 18:37   ` Mark Kettenis
2004-10-14 19:09     ` Andrew Cagney
2004-10-14 19:48       ` Mark Kettenis
2004-10-14 19:59         ` Andrew Cagney
2004-10-15  2:16         ` Michael Chastain [this message]
2004-10-14 21:11     ` Eli Zaretskii
2004-10-14 23:03       ` Andreas Schwab
2004-10-15 12:43         ` Eli Zaretskii
2004-10-15 13:48           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=416F32E7.nail3XL2STGUE@mindspring.com \
    --to=mec.gnu@mindspring.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox