From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7530 invoked by alias); 15 Oct 2004 02:16:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7523 invoked from network); 15 Oct 2004 02:16:12 -0000 Received: from unknown (HELO barry.mail.mindspring.net) (207.69.200.25) by sourceware.org with SMTP; 15 Oct 2004 02:16:12 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by barry.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1CIHda-0003B2-00; Thu, 14 Oct 2004 22:16:10 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 9F3D94B102; Thu, 14 Oct 2004 22:16:10 -0400 (EDT) Date: Fri, 15 Oct 2004 02:16:00 -0000 From: Michael Chastain To: kettenis@gnu.org, cagney@gnu.org Subject: Re: [COMMIT] Accept "\r\n" line-endings on all hosts Cc: gdb-patches@sources.redhat.com Message-ID: <416F32E7.nail3XL2STGUE@mindspring.com> References: <200410141244.i9ECiXMQ008862@elgar.sibelius.xs4all.nl> <416E835F.9040702@gnu.org> <200410141837.i9EIbJCO000581@elgar.sibelius.xs4all.nl> <416ECEE0.8010205@gnu.org> <200410141948.i9EJmirp001178@elgar.sibelius.xs4all.nl> In-Reply-To: <200410141948.i9EJmirp001178@elgar.sibelius.xs4all.nl> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-10/txt/msg00264.txt.bz2 Hi Mark, A good idea, but a few corrections please. # Please email any bugs, comments, and/or additions to this file to: # bug-gdb@gnu.org Drop this part. set file [open "crlf.gdb" "w"] puts -nonewline $file "info break\r\n" close $file Usually I would prefer to have crlf.gdb be a static file. In view of the critical nature of the "\r\n" part, I agree with Andrew's analysis, doing this in TCL is safer than relying on cvs to preserve the line endings. But it needs error checking on the statements with external effect, especially "open". remote_file build delete "crlf.gdb" remote_file host delete $cmdfile Drop these. It's good to leave small files lying around after a test -- makes it easier to debug if anything goes wrong. * gdb.base/crlf.exp: New file. Michael