From: Andrew Cagney <cagney@gnu.org>
To: Paul Hilfinger <hilfingr@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Remove warnings from ada-exp.tab.c compilation
Date: Tue, 05 Oct 2004 19:47:00 -0000 [thread overview]
Message-ID: <4162FA1F.2030207@gnu.org> (raw)
In-Reply-To: <20041005103727.938AEF2BD3@nile.gnat.com>
> +/* FIXME: Temporary measure to remove warning. The function
I'd write this as:
/* FIXME: hilfingr/2004-10-05: Hack to remove warning. ...
so that who added the note and when are clear. If you're curious grep
for this pattern in the sources and quickly discover how old some of
those tempoary hacks are :-)
otherwize ok,
Andrew
PS:
+ tempbuf = (char *) realloc (tempbuf, tempbufsize);
the cast is redundant - realloc returns (void *).
Andrew
next prev parent reply other threads:[~2004-10-05 19:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 10:37 Paul Hilfinger
2004-10-05 19:47 ` Andrew Cagney [this message]
2004-10-06 9:31 ` Paul Hilfinger
2004-10-06 9:47 ` Paul Hilfinger
2004-10-06 10:14 ` Andreas Schwab
2004-10-06 16:29 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4162FA1F.2030207@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=hilfingr@gnat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox