Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Hilfinger <hilfingr@gnat.com>
To: cagney@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Remove warnings from ada-exp.tab.c compilation
Date: Wed, 06 Oct 2004 09:47:00 -0000	[thread overview]
Message-ID: <20041006094738.A6034F2C9D@nile.gnat.com> (raw)
In-Reply-To: <4162FA1F.2030207@gnu.org> (message from Andrew Cagney on Tue, 05 Oct 2004 15:46:39 -0400)


> I'd write this as:
> 
> 	/* FIXME: hilfingr/2004-10-05: Hack to remove warning.  ...
> 
> so that who added the note and when are clear.  If you're curious grep 
> for this pattern in the sources and quickly discover how old some of 
> those tempoary hacks are :-)

Thanks for the suggestion.

> _otherwize_ ok,

Is that a Canadian spelling (:->)?

> PS:
> +      tempbuf = (char *) realloc (tempbuf, tempbufsize);
> the cast is redundant - realloc returns (void *).

Yeah, well, call it a personal quirk, call it an act of rebellion.
But when I see an ISO standard that tells me I don't need this conversion
by saying that

   "A pointer to void shall have the same representation and 
    alignment requirements as a pointer to a character type."

and then tells me IN A FOOTNOTE that 

   "The same representation and alignment requirements are meant to
    imply interchangeability as arguments to functions, return values
    from functions, and members of unions."

the horror I feel at this shameless confusion of abstraction layers is such
that I feel compelled to ignore the passages altogether (:->).

Paul Hilfinger


  parent reply	other threads:[~2004-10-06  9:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-05 10:37 Paul Hilfinger
2004-10-05 19:47 ` Andrew Cagney
2004-10-06  9:31   ` Paul Hilfinger
2004-10-06  9:47   ` Paul Hilfinger [this message]
2004-10-06 10:14     ` Andreas Schwab
2004-10-06 16:29     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041006094738.A6034F2C9D@nile.gnat.com \
    --to=hilfingr@gnat.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox