Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Chastain <mec.gnu@mindspring.com>
To: gdb-patches@sources.redhat.com, drow@false.org
Subject: Re: [testsuite] Add test for setting breakpoints by full path
Date: Wed, 22 Sep 2004 20:07:00 -0000	[thread overview]
Message-ID: <4151DB7F.nailKQ01M3AYJ@mindspring.com> (raw)
In-Reply-To: <20040920001159.GA20633@nevyn.them.org>

[I'm back ... hello mailbox backlog!]

Pretty good, but I see some nits:

. fullname.c needs to #include <stdio.h> to avoid a warning with
  gcc 4.0.0 about implicit internal function on printf.

. test the return value on "file copy -force ..."

. In the call to gdb_get_line_number, it's not necessary to call
  gdb_exit / gdb_start / gdb_load before and after the call to
  gdb_get_line_number.  The new gdb_get_line_number is pure TCL
  code that greps the file without talking to gdb, so you don't
  have to initialize gdb before using it.

. In gdb_breakpoint, only allow-pending or no-message can be used,
  but not both, because both tests use [lindex $args 0].  Either
  document this bit of cheesiness and leave it for the future to fix,
  or get in and fix the TCL.

Michael

2004-09-19  Daniel Jacobowitz  <dan@debian.org>

	* gdb.base/fullname.c: New file.
	* gdb.base/fullname.exp: New file.
	* lib/gdb.exp (gdb_breakpoint): Support no-message option.


  parent reply	other threads:[~2004-09-22 20:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-20  0:12 Daniel Jacobowitz
2004-09-20  0:18 ` Daniel Jacobowitz
2004-09-22 20:07 ` Michael Chastain [this message]
2004-10-04 22:00   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4151DB7F.nailKQ01M3AYJ@mindspring.com \
    --to=mec.gnu@mindspring.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox