From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31839 invoked by alias); 22 Sep 2004 20:07:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31727 invoked from network); 22 Sep 2004 20:07:34 -0000 Received: from unknown (HELO maynard.mail.mindspring.net) (207.69.200.243) by sourceware.org with SMTP; 22 Sep 2004 20:07:34 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by maynard.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1CADOn-0005Rj-00; Wed, 22 Sep 2004 16:07:33 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 58A6A4B102; Wed, 22 Sep 2004 16:07:29 -0400 (EDT) Date: Wed, 22 Sep 2004 20:07:00 -0000 From: Michael Chastain To: gdb-patches@sources.redhat.com, drow@false.org Subject: Re: [testsuite] Add test for setting breakpoints by full path Message-ID: <4151DB7F.nailKQ01M3AYJ@mindspring.com> References: <20040920001159.GA20633@nevyn.them.org> In-Reply-To: <20040920001159.GA20633@nevyn.them.org> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00357.txt.bz2 [I'm back ... hello mailbox backlog!] Pretty good, but I see some nits: . fullname.c needs to #include to avoid a warning with gcc 4.0.0 about implicit internal function on printf. . test the return value on "file copy -force ..." . In the call to gdb_get_line_number, it's not necessary to call gdb_exit / gdb_start / gdb_load before and after the call to gdb_get_line_number. The new gdb_get_line_number is pure TCL code that greps the file without talking to gdb, so you don't have to initialize gdb before using it. . In gdb_breakpoint, only allow-pending or no-message can be used, but not both, because both tests use [lindex $args 0]. Either document this bit of cheesiness and leave it for the future to fix, or get in and fix the TCL. Michael 2004-09-19 Daniel Jacobowitz * gdb.base/fullname.c: New file. * gdb.base/fullname.exp: New file. * lib/gdb.exp (gdb_breakpoint): Support no-message option.