[commit] gnu-v3-abi.c:430: warning: assignment from incompatible pointer type

[commit] gnu-v3-abi.c:430: warning: assignment from incompatible pointer type

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

Hello,

Using FC3's GCC 3.4, I'm seeing the warning:

/home/cygnus/cagney/GDB/src/gdb/gnu-v3-abi.c: In function `init_gnuv3_ops':
/home/cygnus/cagney/GDB/src/gdb/gnu-v3-abi.c:430: warning: assignment 
from incom
patible pointer type
/home/cygnus/cagney/GDB/src/gdb/gnu-v3-abi.c:431: warning: assignment 
from incom
patible pointer type

I'm not sure how it should be fixed (it's messy, see patch for 
description) - suggestions?  For the moment I've disabled -Werror on 
that file.

committed,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1073 bytes --]

2004-09-16  Andrew Cagney  <cagney@gnu.org>

	* Makefile.in (gnu-v3-abi.o): Add explict rule to avoid -Werror
	problem.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.619
diff -p -u -r1.619 Makefile.in
--- Makefile.in	13 Sep 2004 20:55:36 -0000	1.619
+++ Makefile.in	16 Sep 2004 18:11:47 -0000
@@ -1432,6 +1432,14 @@ main.o: main.c
 	$(CC) -c $(INTERNAL_CFLAGS) $(TARGET_SYSTEM_ROOT_DEFINE) \
 		-DBINDIR=\"$(bindir)\" $(srcdir)/main.c
 
+# FIXME: cagney/2004-09-16: "gnu-v3-abi.c", with a GCC 3.4 compiler,
+# gets a "assignment from incompatible pointer type" warning.  The
+# return types - "enum gnu_v3_dtor_kinds" vs "enum ctor_kinds" -
+# conflict.
+gnu-v3-abi.o: $(srcdir)/gnu-v3-abi.c
+	$(CC) -c $(INTERNAL_WARN_CFLAGS) $(NO_WERROR_CFLAGS) \
+		$(srcdir)/gnu-v3-abi.c
+
 # FIXME: cagney/2003-08-10: "monitor.c" gets -Wformat-nonliteral
 # errors.  It turns out that that is the least of monitor.c's
 # problems.  The function print_vsprintf appears to be using

Re: [commit] gnu-v3-abi.c:430: warning: assignment from incompatible pointer type

[Daniel Jacobowitz]

On Thu, Sep 16, 2004 at 02:12:53PM -0400, Andrew Cagney wrote:
> Hello,
> 
> Using FC3's GCC 3.4, I'm seeing the warning:
> 
> /home/cygnus/cagney/GDB/src/gdb/gnu-v3-abi.c: In function `init_gnuv3_ops':
> /home/cygnus/cagney/GDB/src/gdb/gnu-v3-abi.c:430: warning: assignment 
> from incom
> patible pointer type
> /home/cygnus/cagney/GDB/src/gdb/gnu-v3-abi.c:431: warning: assignment 
> from incom
> patible pointer type
> 
> I'm not sure how it should be fixed (it's messy, see patch for 
> description) - suggestions?  For the moment I've disabled -Werror on 
> that file.

We could remove the ctor_kinds/dtor_kinds types from the header and use
the gnu_v3 enums provided by the demangler.  They're misnamed for our
purposes, but they're also a superset of what's available in other ABIs
we currently support.

-- 
Daniel Jacobowitz