From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Assume thread-db loaded over a live process
Date: Mon, 13 Sep 2004 18:44:00 -0000 [thread overview]
Message-ID: <4145EA88.2050401@redhat.com> (raw)
In-Reply-To: <4145A745.6090603@gnu.org>
Andrew Cagney wrote:
> Hello,
>
> This patch changes:
>
> - /* We can only poke around if there actually is a child process.
> - If there is no child process alive, postpone the steps below
> - until one has been created. */
> - if (proc_handle.pid != 0)
> - {
> - enable_thread_event_reporting ();
> - thread_db_find_new_threads ();
> - }
> + enable_thread_event_reporting ();
> + thread_db_find_new_threads ();
>
> this code is only executed when there is a child process so the guard
> isn't needed. Tested on GNU/Linux, no change in test results.
>
> ok?
From memory, I think this code was to guard against the corefile case.
When you load a corefile, you may call thread_db_new_objfile, but
you won't have a child process. Is that no longer the case? Does
loading a corefile no longer cause this function to be called?
next prev parent reply other threads:[~2004-09-13 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 13:59 Andrew Cagney
2004-09-13 14:27 ` Daniel Jacobowitz
2004-09-13 18:44 ` Michael Snyder [this message]
2004-09-13 21:51 ` Andrew Cagney
2004-09-13 22:51 ` Michael Snyder
2004-09-13 22:59 ` Daniel Jacobowitz
2004-09-14 0:42 ` Michael Snyder
2004-09-14 14:39 ` Andrew Cagney
2004-09-13 19:26 Howell, David P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4145EA88.2050401@redhat.com \
--to=msnyder@redhat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox