From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Assume thread-db loaded over a live process
Date: Mon, 13 Sep 2004 14:27:00 -0000 [thread overview]
Message-ID: <20040913142702.GA3809@nevyn.them.org> (raw)
In-Reply-To: <4145A745.6090603@gnu.org>
On Mon, Sep 13, 2004 at 09:57:25AM -0400, Andrew Cagney wrote:
> Hello,
>
> This patch changes:
>
> - /* We can only poke around if there actually is a child process.
> - If there is no child process alive, postpone the steps below
> - until one has been created. */
> - if (proc_handle.pid != 0)
> - {
> - enable_thread_event_reporting ();
> - thread_db_find_new_threads ();
> - }
> + enable_thread_event_reporting ();
> + thread_db_find_new_threads ();
>
> this code is only executed when there is a child process so the guard
> isn't needed. Tested on GNU/Linux, no change in test results.
Historical note: this code is older than the !target_has_execution
check above. It used to be reachable, and was for the static
executable case.
Seems a reasonable change to me.
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-09-13 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 13:59 Andrew Cagney
2004-09-13 14:27 ` Daniel Jacobowitz [this message]
2004-09-13 18:44 ` Michael Snyder
2004-09-13 21:51 ` Andrew Cagney
2004-09-13 22:51 ` Michael Snyder
2004-09-13 22:59 ` Daniel Jacobowitz
2004-09-14 0:42 ` Michael Snyder
2004-09-14 14:39 ` Andrew Cagney
2004-09-13 19:26 Howell, David P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040913142702.GA3809@nevyn.them.org \
--to=drow@false.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox