Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Michael Chastain <mec.gnu@mindspring.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/testsuite] revert return-type of gdb_file_cmd, gdb_load
Date: Fri, 10 Sep 2004 18:11:00 -0000	[thread overview]
Message-ID: <4141EFBF.2010009@gnu.org> (raw)
In-Reply-To: <4140FD5A.nail2UI11H9ND@mindspring.com>

> I hope this is the end of the mess, but if it's not, just let me know!

Thanks!  (Joel, my mips patches will no longer be flying blind ;-)

> This patch reverts the recent change to the return value of gdb_file_cmd.
> Instead of using a structured return value, I just stick the secondary
> information into a global variable.

What of two interfaces -> an existing one with preserved behavior and a 
new one with extended behavior?

> Global variable.  Bleagh.  But "bleagh" beats "oh shit, I broke eight
> other implementations of gdb_load in config/*.exp and I can't test all
> of them".
> 
> Tested on native i686-pc-linux-gnu, gcc 2.95.3 3.3.4 3.4.1,
> dwarf-2 and stabs+, with tcl 8.4.6, expect 5.41, dejagnu 1.4.4.
> 
> I also tested gdb.gdb/*.exp with a stripped gdb to check for
> the proper "untested" results.
> 
> I am committing this now.

Andrew



  reply	other threads:[~2004-09-10 18:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-10  1:03 Michael Chastain
2004-09-10 18:11 ` Andrew Cagney [this message]
2004-09-10 18:30   ` Michael Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4141EFBF.2010009@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox