From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15847 invoked by alias); 10 Sep 2004 18:11:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15831 invoked from network); 10 Sep 2004 18:11:10 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 10 Sep 2004 18:11:10 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8AIB9wC003241 for ; Fri, 10 Sep 2004 14:11:09 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8AIB4303959; Fri, 10 Sep 2004 14:11:09 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D3F7028D2; Fri, 10 Sep 2004 14:17:35 -0400 (EDT) Message-ID: <4141EFBF.2010009@gnu.org> Date: Fri, 10 Sep 2004 18:11:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Michael Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/testsuite] revert return-type of gdb_file_cmd, gdb_load References: <4140FD5A.nail2UI11H9ND@mindspring.com> In-Reply-To: <4140FD5A.nail2UI11H9ND@mindspring.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00169.txt.bz2 > I hope this is the end of the mess, but if it's not, just let me know! Thanks! (Joel, my mips patches will no longer be flying blind ;-) > This patch reverts the recent change to the return value of gdb_file_cmd. > Instead of using a structured return value, I just stick the secondary > information into a global variable. What of two interfaces -> an existing one with preserved behavior and a new one with extended behavior? > Global variable. Bleagh. But "bleagh" beats "oh shit, I broke eight > other implementations of gdb_load in config/*.exp and I can't test all > of them". > > Tested on native i686-pc-linux-gnu, gcc 2.95.3 3.3.4 3.4.1, > dwarf-2 and stabs+, with tcl 8.4.6, expect 5.41, dejagnu 1.4.4. > > I also tested gdb.gdb/*.exp with a stripped gdb to check for > the proper "untested" results. > > I am committing this now. Andrew