Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Chastain <mec.gnu@mindspring.com>
To: jmolenda@apple.com
Cc: gdb-patches@sources.redhat.com, cagney@gnu.org
Subject: Re: RFA: if/while commands in user-defined command behave differently
Date: Fri, 10 Sep 2004 00:55:00 -0000	[thread overview]
Message-ID: <4140FB80.nail29R1BD8KR@mindspring.com> (raw)
In-Reply-To: <F80AC304-02C1-11D9-9D0C-000A9569836A@apple.com>

Jason Molenda <jmolenda@apple.com> wrote:
> OK, I switched to gdb_test_multiple, thanks for the feedback.  I 
> haven't used gdb_test_multiple before, but I think this patch is 
> correct.

Just assert that you re-tested it, and it's approved.
(I'm a weird combination of anal-retentive and trusting).

> I haven't heard anything back on the CLI change.  If the testsuite 
> change is approved, should I commit that and file a PR to track the 
> bug?  :-)

Actually, I like it that way.  But you've been working on GDB longer
than I have, so I leave it to your judgement when/if to file a PR.

Michael

===

2004-09-09  Jason Molenda  (jmolenda@apple.com)

         * gdb.base/define.exp: Two new tests to verify zero space chars
         after 'if' and 'while' commands in a user-defined command is 
	correctly parsed.


  reply	other threads:[~2004-09-10  0:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-08 19:30 Jason Molenda
2004-09-09 14:34 ` Michael Chastain
2004-09-10  0:40   ` Jason Molenda
2004-09-10  0:55     ` Michael Chastain [this message]
2004-09-10  0:58       ` Jason Molenda
2004-09-10  1:19 ` Daniel Jacobowitz
2004-09-10 23:13   ` [Committed] " Jason Molenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4140FB80.nail29R1BD8KR@mindspring.com \
    --to=mec.gnu@mindspring.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jmolenda@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox