From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19287 invoked by alias); 10 Sep 2004 00:55:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19280 invoked from network); 10 Sep 2004 00:55:30 -0000 Received: from unknown (HELO hall.mail.mindspring.net) (207.69.200.60) by sourceware.org with SMTP; 10 Sep 2004 00:55:30 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by hall.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1C5ZhG-0004gb-00; Thu, 09 Sep 2004 20:55:26 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 56D9D4B102; Thu, 9 Sep 2004 20:55:29 -0400 (EDT) Date: Fri, 10 Sep 2004 00:55:00 -0000 From: Michael Chastain To: jmolenda@apple.com Subject: Re: RFA: if/while commands in user-defined command behave differently Cc: gdb-patches@sources.redhat.com, cagney@gnu.org Message-ID: <4140FB80.nail29R1BD8KR@mindspring.com> References: <76449857-01CD-11D9-9838-000A9569836A@apple.com> <414069F8.nailE691CTVHR@mindspring.com> In-Reply-To: User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00157.txt.bz2 Jason Molenda wrote: > OK, I switched to gdb_test_multiple, thanks for the feedback. I > haven't used gdb_test_multiple before, but I think this patch is > correct. Just assert that you re-tested it, and it's approved. (I'm a weird combination of anal-retentive and trusting). > I haven't heard anything back on the CLI change. If the testsuite > change is approved, should I commit that and file a PR to track the > bug? :-) Actually, I like it that way. But you've been working on GDB longer than I have, so I leave it to your judgement when/if to file a PR. Michael === 2004-09-09 Jason Molenda (jmolenda@apple.com) * gdb.base/define.exp: Two new tests to verify zero space chars after 'if' and 'while' commands in a user-defined command is correctly parsed.