From: Andrew Cagney <cagney@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit] Let {TM,XM,NM}_FILE specify a path
Date: Thu, 09 Sep 2004 15:17:00 -0000 [thread overview]
Message-ID: <414073FE.90601@gnu.org> (raw)
In-Reply-To: <01c49274$Blat.v2.2.2$507011c0@zahav.net.il>
>>> Date: Fri, 03 Sep 2004 12:38:18 -0400
>>> From: Andrew Cagney <cagney@gnu.org>
>>> Cc: gdb-patches@sources.redhat.com
>>>
>>
>>>> > Perhaps we should rename TM_FILE to something like TM_INCLUDE, then.
>>
>>>
>>> If you prefer, I can rename it to DEPRECATED_TM_INCLUDE when committing
>>> my pending deprecation patch.
>
>
> If we change the functionality of TM_FILE (so it can now name any
> file), then it doesn't seem to be deprecated. Thus,
> DEPRECATED_TM_INCLUDE seems an inappropriate name to me.
I've now prototyped this change vis:
TM_FILE -> TM_INCLUDE
NAT_FILE -> NM_INCLUDE (for consistency)
XM_FILE -> XM_INCLUDE
and found that it didn't help.
TM_FILE specifies the name of the file that is linked to "tm.h". My
patch does not change this. It just removes a restriction on what could
be specified for that file.
If we were to say, eliminate "tm.h", and instead include the tm file
directly than I could certainly see some sort of name change vis:
#ifdef TM_INCLUDE_FILE
#include TM_INCLUDE_FILE
#endif
I've also prototyped this. I discarded it - I didn't see sufficient
value add.
Andrew
next prev parent reply other threads:[~2004-09-09 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-02 22:13 Andrew Cagney
2004-09-03 11:17 ` Eli Zaretskii
2004-09-03 16:39 ` Andrew Cagney
2004-09-04 11:42 ` Eli Zaretskii
2004-09-09 15:17 ` Andrew Cagney [this message]
2004-09-09 19:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414073FE.90601@gnu.org \
--to=cagney@gnu.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox