From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30013 invoked by alias); 9 Sep 2004 15:17:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29977 invoked from network); 9 Sep 2004 15:17:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 9 Sep 2004 15:17:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i89FHTS2004122 for ; Thu, 9 Sep 2004 11:17:34 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i89FHN329136; Thu, 9 Sep 2004 11:17:23 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id BE81E28D2; Thu, 9 Sep 2004 11:17:18 -0400 (EDT) Message-ID: <414073FE.90601@gnu.org> Date: Thu, 09 Sep 2004 15:17:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Let {TM,XM,NM}_FILE specify a path References: <41379AC6.90605@gnu.org> <01c491a7$Blat.v2.2.2$8cce1ae0@zahav.net.il> <41389DFA.5020104@gnu.org> <01c49274$Blat.v2.2.2$507011c0@zahav.net.il> In-Reply-To: <01c49274$Blat.v2.2.2$507011c0@zahav.net.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00145.txt.bz2 >>> Date: Fri, 03 Sep 2004 12:38:18 -0400 >>> From: Andrew Cagney >>> Cc: gdb-patches@sources.redhat.com >>> >> >>>> > Perhaps we should rename TM_FILE to something like TM_INCLUDE, then. >> >>> >>> If you prefer, I can rename it to DEPRECATED_TM_INCLUDE when committing >>> my pending deprecation patch. > > > If we change the functionality of TM_FILE (so it can now name any > file), then it doesn't seem to be deprecated. Thus, > DEPRECATED_TM_INCLUDE seems an inappropriate name to me. I've now prototyped this change vis: TM_FILE -> TM_INCLUDE NAT_FILE -> NM_INCLUDE (for consistency) XM_FILE -> XM_INCLUDE and found that it didn't help. TM_FILE specifies the name of the file that is linked to "tm.h". My patch does not change this. It just removes a restriction on what could be specified for that file. If we were to say, eliminate "tm.h", and instead include the tm file directly than I could certainly see some sort of name change vis: #ifdef TM_INCLUDE_FILE #include TM_INCLUDE_FILE #endif I've also prototyped this. I discarded it - I didn't see sufficient value add. Andrew