Re: [rfa] Delete keep_thread_db

[Andrew Cagney <cagney@gnu.org>]

> Michael Snyder <msnyder@redhat.com> wrote: 
> 
> 
>>> Andrew Cagney wrote:
>>
>>>> > It would appear that, at one stage, this variable had something to do 
>>>> > with corefiles, static programs and threads.  That's no longer the case 
>>>> > so this deletes the stray global.
>>>> > 
>>>> > Tested on FC3 with no regressions,
>>>> > 
>>>> > Ok?
>>>> > Andrew
>>
>>> 
>>> I would have to defer to Mark Kettenis, since he added the
>>> variable, and from the ChangeLogs, seems to be the only one
>>> who's touched it.
> 
> 
> The code defenitely was there to deal with static binaries.  Andrew, how did you come to the conclusion that it is no longer useful?  AFAIK there is no static threads test in the testsuite.

I recently added a test case for this feature - staticthreads.exp.
It fails.

> Anyway, I don't care about this code anymore.  I've given up on debugging-with threads on Linux.  thread-db.c should renamed into linux-thread.c or somesuch.  It, and lin-lwp.c have become a mess of workarounds around workarounds around workarounds that probably only work if you run a specific combination of glibc and patched kernel.
> 
> So I'm not going to explicitly OK or this patch.  Just rely on your own judgement here Andrew.

Andrew