From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1570 invoked by alias); 8 Sep 2004 14:15:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1489 invoked from network); 8 Sep 2004 14:15:21 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 8 Sep 2004 14:15:21 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i88EFAS2017143 for ; Wed, 8 Sep 2004 10:15:16 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i88EF4303836; Wed, 8 Sep 2004 10:15:04 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 34C7628D2; Wed, 8 Sep 2004 10:14:54 -0400 (EDT) Message-ID: <413F13DD.6070209@gnu.org> Date: Wed, 08 Sep 2004 14:15:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: "M.M. Kettenis" Cc: Michael Snyder , gdb-patches@sources.redhat.com, kettenis@gnu.org Subject: Re: [rfa] Delete keep_thread_db References: <7318322520085180@weblx058.utsp.utwente.nl> In-Reply-To: <7318322520085180@weblx058.utsp.utwente.nl> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00120.txt.bz2 > Michael Snyder wrote: > > >>> Andrew Cagney wrote: >> >>>> > It would appear that, at one stage, this variable had something to do >>>> > with corefiles, static programs and threads. That's no longer the case >>>> > so this deletes the stray global. >>>> > >>>> > Tested on FC3 with no regressions, >>>> > >>>> > Ok? >>>> > Andrew >> >>> >>> I would have to defer to Mark Kettenis, since he added the >>> variable, and from the ChangeLogs, seems to be the only one >>> who's touched it. > > > The code defenitely was there to deal with static binaries. Andrew, how did you come to the conclusion that it is no longer useful? AFAIK there is no static threads test in the testsuite. I recently added a test case for this feature - staticthreads.exp. It fails. > Anyway, I don't care about this code anymore. I've given up on debugging-with threads on Linux. thread-db.c should renamed into linux-thread.c or somesuch. It, and lin-lwp.c have become a mess of workarounds around workarounds around workarounds that probably only work if you run a specific combination of glibc and patched kernel. > > So I'm not going to explicitly OK or this patch. Just rely on your own judgement here Andrew. Andrew