[PATCH] Remove UINT_MAX undef from powerpc/xm-aix.h

[PATCH] Remove UINT_MAX undef from powerpc/xm-aix.h

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

Re: http://sources.redhat.com/ml/gdb-patches/2004-08/msg00428.html

I have committed the following change. I tested this change by checking
visually that the value defined by the system is identical to the value
provided by GDB. I also tested it by running the testsuite on both
AIX 4.3.2 and 5.1. No regression.

2004-08-11  Joel Brobecker  <brobecker@gnat.com>

        * config/powerpc/xm-aix.h (UINT_MAX): Remove undef.

If it turns out that we need this on a certain system, I will fix the
problem in directly in configure.

-- 
Joel

[-- Attachment #2: xm.diff --]
[-- Type: text/plain, Size: 714 bytes --]

Index: xm-aix.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/xm-aix.h,v
retrieving revision 1.5
diff -u -p -r1.5 xm-aix.h
--- xm-aix.h	11 Aug 2004 22:28:33 -0000	1.5
+++ xm-aix.h	12 Aug 2004 04:59:39 -0000
@@ -18,9 +18,3 @@
    along with this program; if not, write to the Free Software
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
-
-/* UINT_MAX is defined in <sys/limits.h> as a decimal constant (4294967295)
-   which is too large to fit in a signed int when it is parsed by the
-   compiler, so it issues a diagnostic.  Just undef it here so that we
-   use gdb's version in defs.h */
-#undef UINT_MAX

Re: [PATCH] Remove UINT_MAX undef from powerpc/xm-aix.h

[Michael Chastain]

Joel Brobecker <brobecker@gnat.com> wrote:
> I also tested it by running the testsuite on both AIX 4.3.2 and 5.1.

What compiler are you using to build gdb: gcc, or some IBM compiler,
or both?

Just looking at the comment, I suspect that the #undef was there
to work around a compiler warning from some IBM compiler.

Michael C

Re: [PATCH] Remove UINT_MAX undef from powerpc/xm-aix.h

[Daniel Jacobowitz]

On Thu, Aug 12, 2004 at 07:46:32AM -0400, Michael Chastain wrote:
> Joel Brobecker <brobecker@gnat.com> wrote:
> > I also tested it by running the testsuite on both AIX 4.3.2 and 5.1.
> 
> What compiler are you using to build gdb: gcc, or some IBM compiler,
> or both?
> 
> Just looking at the comment, I suspect that the #undef was there
> to work around a compiler warning from some IBM compiler.

GCC would generate the same warning; it would be a bug in the AIX
system headers for some old AIX.

-- 
Daniel Jacobowitz

Re: [PATCH] Remove UINT_MAX undef from powerpc/xm-aix.h

[Joel Brobecker]

> What compiler are you using to build gdb: gcc, or some IBM compiler,
> or both?

Just for the record, I'm using GCC.

-- 
Joel