[patch/testsuite] ChangeLog: add copyright notice

[patch/testsuite] ChangeLog: add copyright notice

[Michael Chastain]

This patch adds a copyright notice to testsuite/ChangeLog.

Yup, "Information for Maintainers of GNU Software" says that ChangeLog
files shall have copyright notices:

  http://www.gnu.org/prep/maintain_8.html

  "Change log files should have a copyright notice and license notice at
   the end, since new material is added at the beginning but the end
   remains the end."

Date sources: the ChangeLog file itself.

Testing: not tested.  I hope this doesn't screw up anybody's emacs.

I think this patch is pretty funny.  And you guys can be happy that
there is only one ChangeLog file in my area of maintenance.  :)

I'll give this 24 hours for comments, more if it's controversial,
and then commit it.

Michael C

2004-08-06  Michael Chastain  <mec.gnu@mindspring.com>

	* ChangeLog: Add copyright notice.

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.969
diff -c -3 -p -r1.969 ChangeLog
*** ChangeLog	5 Aug 2004 07:44:47 -0000	1.969
--- ChangeLog	6 Aug 2004 16:13:44 -0000
*************** Sun Feb 21 10:55:55 1993  Mike Werner  (
*** 12544,12549 ****
--- 12544,12569 ----
  	will allow them to work with the new version of dejagnu will be
  	made in a future update.
  
+ Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
+ 2003, 2004 Free Software Foundation, Inc.
+ 
+ This file is part of GDB.
+ 
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or (at
+ your option) any later version.
+ 
+ This program is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ General Public License for more details.
+ 
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place - Suite 330,
+ Boston, MA 02111-1307, USA.
+ 
  For additional changes see gdb.mi/ChangeLog-1999-2003.
  \f
  Local Variables:

Re: [patch/testsuite] ChangeLog: add copyright notice

[Eli Zaretskii]

> Date: Fri, 06 Aug 2004 12:25:57 -0400
> From: Michael Chastain <mec.gnu@mindspring.com>
> 
> This patch adds a copyright notice to testsuite/ChangeLog.

Thanks.

> + Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
> + 2003, 2004 Free Software Foundation, Inc.
> + 
> + This file is part of GDB.
> + 
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 2 of the License, or (at
> + your option) any later version.
> + 
> + This program is distributed in the hope that it will be useful, but
> + WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + General Public License for more details.
> + 
> + You should have received a copy of the GNU General Public License
> + along with this program; if not, write to the Free Software
> + Foundation, Inc., 59 Temple Place - Suite 330,
> + Boston, MA 02111-1307, USA.
> + 
>   For additional changes see gdb.mi/ChangeLog-1999-2003.
>   \f
>   Local Variables:

I have two comments on this:

 (1) The text is excessively long.  I attach below the copyright blurb
     from the Emacs ChangeLog files; I think what's good for RMS is
     good enough for us.

 (2) It should go _after_ the "Local Variables" section.

Here's the copyright found in Emacs ChangeLog files.  Note the
semi-colons in the Local Variables lines: they make sure their
fontification in Emacs isn't screwed up (like they are in GDB).

----------------------------- cut here -------------------------
;; Local Variables:
;; coding: iso-2022-7bit
;; End:

    Copyright (C) 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2001, 2002
	Free Software Foundation, Inc.
  Copying and distribution of this file, with or without modification,
  are permitted provided the copyright notice and this notice are preserved.

Re: [patch/testsuite] ChangeLog: add copyright notice

[Michael Chastain]

Okay, here is a revised patch.  Eli, can you check it in your emacs?
I'm emacs-illiterate.

The blurb from Emacs 21.3 is fine by me.  I credited it in the
ChangeLog.

eliz>  (2) It should go _after_ the "Local Variables" section.

Gotcha.

> Note the semi-colons in the Local Variables lines: they make sure
> their fontification in Emacs isn't screwed up (like they are in GDB).

When I add a copyright notice, that's the only change I make in that
patch.

I'd be happy to receive a separate patch from an emacs user to fix
anything emacs-related.

So ... does this patch work for you, Eli?

===

2004-08-07  Michael Chastain  <mec.gnu@mindspring.com>

	* ChangeLog: Add copyright notice.  The notice is copied
	from emacs 21.3 top level ChangeLog.

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.969
diff -c -3 -p -r1.969 ChangeLog
*** ChangeLog	5 Aug 2004 07:44:47 -0000	1.969
--- ChangeLog	7 Aug 2004 23:01:50 -0000
*************** left-margin: 8
*** 12552,12554 ****
--- 12552,12559 ----
  fill-column: 74
  version-control: never
  End:
+ 
+     Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
+     2003, 2004 Free Software Foundation, Inc.
+   Copying and distribution of this file, with or without modification,
+   are permitted provided the copyright notice and this notice are preserved.

Re: [patch/testsuite] ChangeLog: add copyright notice

[Eli Zaretskii]

> Date: Sat, 07 Aug 2004 19:06:49 -0400
> From: Michael Chastain <mec.gnu@mindspring.com>
> 
> Okay, here is a revised patch.  Eli, can you check it in your emacs?

Done (sorry for the long delay).

> > Note the semi-colons in the Local Variables lines: they make sure
> > their fontification in Emacs isn't screwed up (like they are in GDB).
> 
> When I add a copyright notice, that's the only change I make in that
> patch.

This principle is okay for patching code, but for such small changes
in something other than code, I think sticking to it is overkill.

> I'd be happy to receive a separate patch from an emacs user to fix
> anything emacs-related.

Attached below.

> So ... does this patch work for you, Eli?

Yes, thanks.

2004-08-10  Eli Zaretskii  <eliz@gnu.org>

	* ChangeLog: Prefix Local Variables with semi-colons and indent
	the reference to older ChangeLog files, to fix fontification in
	Emacs.

diff -u "gdb/ChangeLog.~0" "gdb/ChangeLog"
--- gdb/ChangeLog.~0	2004-08-10 21:45:50.000000000 +0300
+++ gdb/ChangeLog	2004-08-10 21:52:26.000000000 +0300
@@ -1,3 +1,9 @@
@@ -4090,15 +4096,15 @@
 	in <machine/reg.h>.
 	* configure, config.in: Regenerate.
 
-For older changes see ChangeLog-2003, mi/ChangeLog-1999-2003, and
-tui/ChangeLog-1998-2003.
+ For older changes see ChangeLog-2003, mi/ChangeLog-1999-2003, and
+ tui/ChangeLog-1998-2003.
 \f
-Local Variables:
-mode: change-log
-left-margin: 8
-fill-column: 74
-version-control: never
-End:
+;; Local Variables:
+;; mode: change-log
+;; left-margin: 8
+;; fill-column: 74
+;; version-control: never
+;; End:
 
     Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
     2003, 2004 Free Software Foundation, Inc.

Diff finished.  Tue Aug 10 21:52:53 2004

Re: [patch/testsuite] ChangeLog: add copyright notice

[Michael Chastain]

Okay, I committed this patch.

eliz> This principle is okay for patching code, but for such small changes
eliz> in something other than code, I think sticking to it is overkill.

When it comes to copyright, I'm pretty sticky about principles.

Also there is not much difference between "code" and "other than code"
for copyright purposes.

eliz> Attached below.

Cool, I will review your patch in a few minutes.

Michael C

2004-08-07  Michael Chastain  <mec.gnu@mindspring.com>

	* ChangeLog: Add copyright notice.  The notice is copied
	from emacs 21.3 top level ChangeLog.

Re: [patch/testsuite] ChangeLog: add copyright notice

[Michael Chastain]

Hi Eli,

What system(s) and version(s) of emacs did you test this on?

Michael C

2004-08-10  Eli Zaretskii  <eliz@gnu.org>

	* ChangeLog: Prefix Local Variables with semi-colons and indent
	the reference to older ChangeLog files, to fix fontification in
	Emacs.

Re: [patch/testsuite] ChangeLog: add copyright notice

[Eli Zaretskii]

> Date: Tue, 10 Aug 2004 15:39:55 -0400
> From: Michael Chastain <mec.gnu@mindspring.com>
> 
> What system(s) and version(s) of emacs did you test this on?

The CVS HEAD version of Emacs on Windows 98.

But I don't think this aspect of Emacs changed since v21.1 (several
years ago).

Re: [patch/testsuite] ChangeLog: add copyright notice

[Michael Chastain]

"Eli Zaretskii" <eliz@gnu.org> wrote:
> The CVS HEAD version of Emacs on Windows 98.
> 
> But I don't think this aspect of Emacs changed since v21.1 (several
> years ago).

Good enough for me.  If it somehow doesn't work with stock released
emacs, I guess I'll be receiving another patch.

This patch is approved.

===

2004-08-10  Eli Zaretskii  <eliz@gnu.org>

	* ChangeLog: Prefix Local Variables with semi-colons and indent
	the reference to older ChangeLog files, to fix fontification in
	Emacs.

Re: [patch/testsuite] ChangeLog: add copyright notice

[Eli Zaretskii]

> Date: Wed, 11 Aug 2004 03:46:26 -0400
> From: Michael Chastain <mec.gnu@mindspring.com>
> 
> "Eli Zaretskii" <eliz@gnu.org> wrote:
> > The CVS HEAD version of Emacs on Windows 98.
> > 
> > But I don't think this aspect of Emacs changed since v21.1 (several
> > years ago).
> 
> Good enough for me.  If it somehow doesn't work with stock released
> emacs, I guess I'll be receiving another patch.
> 
> This patch is approved.
> 
> ===
> 
> 2004-08-10  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* ChangeLog: Prefix Local Variables with semi-colons and indent
> 	the reference to older ChangeLog files, to fix fontification in
> 	Emacs.

Committed.