From: Andrew Cagney <cagney@gnu.org>
To: Michael Chastain <mec.gnu@mindspring.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Cleanup store.exp
Date: Thu, 05 Aug 2004 14:02:00 -0000 [thread overview]
Message-ID: <41123DFA.1000708@gnu.org> (raw)
In-Reply-To: <4110619B.nailCV2114VMQ@mindspring.com>
> Andrew Cagney <cagney@gnu.org> wrote:
>
>>> This gets rid of the duplicate test messages in sore.exp. Tested on FC2.
>>> m'kay.
>
>
> This patch is approved.
Committed (I hope).
> I'm particularly happy with this bit:
>
> - gdb_test "print l" " = ${l}" "print old l - ${t}"
> - gdb_test "print r" " = ${r}" "print old r - ${t}"
> + gdb_test "print l" " = ${l}" \
> + "${prefix}; print old l, expecting ${l}"
> + gdb_test "print r" " = ${r}" \
> + "${prefix}; print old r, expecting ${r}"
>
> Maybe it's just me, but when I saw "print old l - int",
> I parsed it as "print old l minus int". So I'm glad to see
> the dash character go away.
Yea, `;' as a convention also works much better.
Andrew
prev parent reply other threads:[~2004-08-05 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 1:50 Andrew Cagney
2004-08-04 4:09 ` Michael Chastain
2004-08-05 14:02 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41123DFA.1000708@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox