From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34881-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 14626 invoked by alias); 5 Aug 2004 14:02:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 14619 invoked from network); 5 Aug 2004 14:02:46 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 5 Aug 2004 14:02:46 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i75E2ke3008128
	for <gdb-patches@sources.redhat.com>; Thu, 5 Aug 2004 10:02:46 -0400
Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i75E2ea03180;
	Thu, 5 Aug 2004 10:02:46 -0400
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id D171D2B9D; Thu,  5 Aug 2004 10:02:34 -0400 (EDT)
Message-ID: <41123DFA.1000708@gnu.org>
Date: Thu, 05 Aug 2004 14:02:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040801
MIME-Version: 1.0
To: Michael Chastain <mec.gnu@mindspring.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] Cleanup store.exp
References: <411040EB.3060904@gnu.org> <4110619B.nailCV2114VMQ@mindspring.com>
In-Reply-To: <4110619B.nailCV2114VMQ@mindspring.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-08/txt/msg00112.txt.bz2

> Andrew Cagney <cagney@gnu.org> wrote:
> 
>>> This gets rid of the duplicate test messages in sore.exp.  Tested on FC2.
>>> m'kay.
> 
> 
> This patch is approved.

Committed (I hope).

> I'm particularly happy with this bit:
> 
>   -    gdb_test "print l" " = ${l}" "print old l - ${t}"
>   -    gdb_test "print r" " = ${r}" "print old r - ${t}"
>   +    gdb_test "print l" " = ${l}" \
>   +	"${prefix}; print old l, expecting ${l}"
>   +    gdb_test "print r" " = ${r}" \
>   +	"${prefix}; print old r, expecting ${r}"
> 
> Maybe it's just me, but when I saw "print old l - int",
> I parsed it as "print old l minus int".  So I'm glad to see
> the dash character go away.

Yea, `;' as a convention also works much better.

Andrew