From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid
Date: Mon, 20 Mar 2017 22:06:00 -0000 [thread overview]
Message-ID: <4107c32b-465f-59b8-35b2-3caf0f5085bf@redhat.com> (raw)
In-Reply-To: <20170320215147.25887-1-simon.marchi@ericsson.com>
On 03/20/2017 09:51 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> New in v2: use scoped_restore to save/restore inferior_ptid.
>
> The implementations of to_fetch_regiters/to_store_registers in the spu
Typo: "regiters".
> code use some functions that rely on inferior_ptid. It's simpler for
> now to set/restore inferior_ptid.
>
> * spu-linux-nat.c (spu_fetch_inferior_registers,
> spu_store_inferior_registers): Use ptid from regcache, set and
> restore inferior_ptid.
> * spu-multiarch.c (spu_fetch_registers, spu_store_registers):
> Likewise.
LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-03-20 22:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 17:08 [PATCH 1/3] Use ptid from regcache in almost all remaining nat files Simon Marchi
2017-03-18 17:08 ` [PATCH 2/3] spu: Use ptid from regcache instead of inferior_ptid Simon Marchi
2017-03-20 15:54 ` Pedro Alves
2017-03-20 21:50 ` Simon Marchi
2017-03-20 21:52 ` [PATCH v2 " Simon Marchi
2017-03-20 22:06 ` Pedro Alves [this message]
2017-03-20 22:24 ` Simon Marchi
2017-03-18 17:08 ` [PATCH 3/3] windows: Use ptid from regcache in register fetch/store Simon Marchi
2017-03-20 15:56 ` Pedro Alves
2017-03-20 22:22 ` Simon Marchi
2017-03-21 14:27 ` Pedro Alves
2017-03-21 15:24 ` Simon Marchi
2017-03-21 15:39 ` [pushed] " Simon Marchi
2017-03-20 15:54 ` [PATCH 1/3] Use ptid from regcache in almost all remaining nat files Pedro Alves
2017-03-20 21:39 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4107c32b-465f-59b8-35b2-3caf0f5085bf@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox