From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3447 invoked by alias); 20 Mar 2017 22:06:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3425 invoked by uid 89); 20 Mar 2017 22:06:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 22:06:13 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20732C0092C1; Mon, 20 Mar 2017 22:06:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 20732C0092C1 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 20732C0092C1 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3F86E4B99; Mon, 20 Mar 2017 22:06:12 +0000 (UTC) Subject: Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid To: Simon Marchi , gdb-patches@sourceware.org References: <20170320215147.25887-1-simon.marchi@ericsson.com> Cc: Simon Marchi From: Pedro Alves Message-ID: <4107c32b-465f-59b8-35b2-3caf0f5085bf@redhat.com> Date: Mon, 20 Mar 2017 22:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170320215147.25887-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00353.txt.bz2 On 03/20/2017 09:51 PM, Simon Marchi wrote: > From: Simon Marchi > > New in v2: use scoped_restore to save/restore inferior_ptid. > > The implementations of to_fetch_regiters/to_store_registers in the spu Typo: "regiters". > code use some functions that rely on inferior_ptid. It's simpler for > now to set/restore inferior_ptid. > > * spu-linux-nat.c (spu_fetch_inferior_registers, > spu_store_inferior_registers): Use ptid from regcache, set and > restore inferior_ptid. > * spu-multiarch.c (spu_fetch_registers, spu_store_registers): > Likewise. LGTM. Thanks, Pedro Alves