Re: [PATCH][gdb/testsuite] Add KFAIL for missing support of reverse-debugging xsave

[Tom de Vries <tdevries@suse.de>]

On 13-10-2019 01:09, Simon Marchi wrote:
> On 2019-09-27 11:11, Tom de Vries wrote:
>> Hi,
>>
>> Normally the gdb.reverse/*.exp test-cases pass on my system (apart
>> from the
>> record/23188 KFAIL for gdb.reverse/step-precsave.exp).  But when
>> specifying
>> GLIBC_TUNABLES=glibc.tune.hwcaps=-XSAVEC_Usable to force glibc to use
>> _dl_runtime_resolve_xsave instead of _dl_runtime_resolve_xsavec, we
>> run into
>> 1054 FAILs like this:
>> ...
>> (gdb) PASS: gdb.reverse/sigall-reverse.exp: b gen_HUP
>> continue^M
>> Continuing.^M
>> Process record does not support instruction 0xfae64 at address \
>>   0x7ffff7ded958.^M
>> Process record: failed to record execution log.^M
>> ^M
>> Program stopped.^M
>> 0x00007ffff7ded958 in _dl_runtime_resolve_xsave () from \
>>   /lib64/ld-linux-x86-64.so.2^M
>> (gdb) FAIL: gdb.reverse/sigall-reverse.exp: get signal ABRT
>> ...
>>
>> The problem is that the xsave instruction is not supported in
>> reverse-debugging (PR record/25038).
>>
>> Add KFAILs for this PR.
>>
>> Tested on x86_64-linux.
>>
>> OK for trunk?
> 
> Hi Tom,
> 
> That looks good to me in general.  Just one note here:
> 
>> @@ -289,8 +295,12 @@ set sig_supported 1
>>  set thissig "ABRT"
>>
>>  # test signal handling
>> +set record_instruction_kfail 0
>>  foreach sig [lrange $signals 1 end] {
>>      test_one_sig $sig
>> +    if { $record_instruction_kfail } {
>> +    return -1
>> +    }
> 
> It seems like record_instruction_kfail is never set in this file,
> sigall-precsave.exp, I suppose it should?

Hi,

thanks for the review. It seems that was some dead code, I've removed it
now and committed.

Thanks,
- Tom